Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-machine: remove deprecate comment #117033

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

As gitlab is actively maintaining the fork, I think it is good to remove the deprecate comment

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Dec 1, 2022
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 1, 2022
@carlocab
Copy link
Member

carlocab commented Dec 1, 2022

Related: #106902 (comment)

@carlocab carlocab requested a review from SMillerDev December 1, 2022 03:31
@SMillerDev
Copy link
Member

Gitlab sees it as deprecated though. I disagree with this.

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should deprecate the dependents too

@chenrui333
Copy link
Member Author

chenrui333 commented Dec 2, 2022

I see, I will also raise a gitlab issue before further pursuing this. (in terms of maintenance commitment)

For the dependents, I agree, most of them are not being actively maintained.

@chenrui333
Copy link
Member Author

Gonna close this for now. Thanks folks!

@chenrui333 chenrui333 closed this Dec 10, 2022
@chenrui333 chenrui333 deleted the docker-machine-remove-deprecate-comment branch December 10, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants