fix(wakatime): incorrect sha256 checksum #181155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.The sha256 checksum for the wakatime cask seems to be incorrect. I tried installing the cask using brew install wakatime and got
I downloaded the cask for (https://github.com/wakatime/macos-wakatime/releases/download/v5.17.0/macos-wakatime.zip) manually and checked the sha256 with shasum -a 256. The values were indeed different, and in the case of arm (which I use) showed the checksum listed above in "Actual".
I understand that updating version & checksum is a task usually performed by a bot (see 401bb55), but in this case something went wrong and brew users cannot install the update. I also understand that changing the checksums opens up the possibility of getting insecure code onto users' machines, but since the source is not changed, I see no harm.