-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Linux data source to Homebrew/homebrew-core #569
Conversation
I've implemented the redirects for the HTML pages; namely, /formula-linux/ => /formula/ and /formula-linux/ƒ => /formula/ƒ. The JSON API, however, can't be properly redirected with what we have on GitHub Pages. Since |
Could we just copy the api files and send this as a feature request to github? |
I think this is fine, we can just drop these files.
Let's not. It won't be implemented in a meaningful timeframe and will bloat this repo until then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me!
Not that it blocked this or anything, but I've informed Repology that the Linux data source is now deprecated and will soon be no more. |
@Bo98 Thanks! |
Thanks for the help, Eric, and for ticking the checklist items in the issue. There's quite a lot complete here! ✨ Over this weekend I'll work on item 2, the formula page: splitting up the views by macOS and Linux dependencies/caveats/bottles and the analytics tables. |
On the "show macOS and Linux analytics in separate tables", I'd quite like to show them in one table with multiple columns inside for macOS and Linux, but I couldn't work out how to do it with all the loops and different paths for |
The issue there is how the stats table markup iterates through each formula's invocation form that appears in each data source, whether just the formula name or with options. To combine the tables would require creating a merged list of these from each data source before fetching the values for each form, if they exist. But, since in core the only possibilities are either |
With for loops implemented and |
This is the last thing to do here, and it feels quite big, and this PR is extremely large already. I know if we don't ship step 3 with steps 1, 2, 4 and 5 we'll be lacking functionality for a bit. But if people are pulling Linux data from this API now they're getting out of date stuff anyway). All that to say, does anyone else have more time than me to work on this part? @Rylan12? |
Am I missing something or is the easiest solution to stop splitting Linux and macOS analytics reporting? |
No, that part is done. The issue now is that anything in formulae that's potentially affected by an |
Eventually, yes, I'd be happy to work on this a bit. At the moment, though, I'm a bit swamped with |
Yes, I'm fine to ship without 3 for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️. Rebase this and merge whenever you get a chance (because there will be inevitable conflicts soon after otherwise).
and fix "full_full_name" typo
197b3ec
to
c4152e8
Compare
I think GitHub is confused by the sheer size of this PR. There were no conflicts when I rebased on |
Thanks @issyl0 and @EricFromCanada ! Without your contributions it'd be impossible to keep homebrew going. You can feel good knowing that you've made the world a lot better for homebrew users around the world! 👍 🎉 |
What I usually do to avoid problems like this is only commit the changes that are to the generation files and not the actual site files. Then, once the PR is merged, the automatic generation is triggered and the updated site is pushed as an additional commit. |
My vague plan here:
formula-linux/
and see what breaks. (This is where I currently am at the time of writing this.)Jekyll is still a mystery to me, so I can't promise this'll be fast.