Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brew #19132

Closed
wants to merge 8 commits into from
Closed

Brew #19132

wants to merge 8 commits into from

Conversation

Kaustavpal007
Copy link

@Kaustavpal007 Kaustavpal007 commented Jan 22, 2025 •
edited
Loading

- [ ] Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Kaustavpal007 and others added 8 commits January 9, 2025 13:35
@Kaustavpal007
Update README.md
e60835e
@Kaustavpal007
Update README.md
56a29be
@Kaustavpal007
Update README.md
b6ca011 
Signed-off-by: Kaustavpal007 <[email protected]>
@Kaustavpal007
Create FUNDING.yml
25680cf 
Thanks And Regards 

Signed-off-by: Kaustavpal007 <[email protected]>
@Kaustavpal007 @github-advanced-security
Potential fix for code scanning alert no. 1: Incomplete regular expre…
e7af88a 
…ssion for hostnames

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Kaustavpal007 <[email protected]>
@Kaustavpal007
Merge pull request #1 from Kaustavpal007/alert-autofix-1
3989dd5
@Kaustavpal007
Update FUNDING.yml
edfe340 
Signed-off-by: Kaustavpal007 <[email protected]>
@Kaustavpal007
Merge branch 'master' into master
569977f
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 22, 2025
View reviewed changes
Library/Homebrew/test/dev-cmd/bottle_spec.rb
@@ -428,7 +428,7 @@

it "checks for conflicting root URL" do
old_spec = BottleSpecification.new
old_spec.root_url("https://failbrew.bintray.com/bottles")
old_spec.root_url("https://failbrew\.bintray\.com/bottles")

Check failure

Code scanning / CodeQL

Incomplete regular expression for hostnames High test

This string, which is used as a regular expression
here
Loading
, has an unescaped '.' before 'bintray.com/bottles', so it might match more hosts than expected.
@carlocab carlocab closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kaustavpal007 @carlocab