cleaner: rewrite pkg-config file Cellar paths and keg-only #18229
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
commented
Sep 2, 2024
| pc_files.each do |pc_file| | ||
| any_modification = T.let(false, T::Boolean) | ||
| lines = pc_file.each_line.map do |line| | ||
| any_modification ||= line.gsub!(@formula.prefix.realpath.to_s, @formula.opt_prefix.to_s).present? |
There was a problem hiding this comment.
One thing is that this doesn't handle multiple copies of formula in Cellar. I guess the more accurate way would be to handle this during link/unlink but that makes logic a bit more complex than always using opt path.
There was a problem hiding this comment.
I think it's fine to not handle multiple formulae in Cellar.
6 tasks
MikeMcQuaid
reviewed
Sep 2, 2024
| keg_only_pc_files = @formula.deps | ||
| .reject { |d| d.build? || d.test? } | ||
| .map(&:to_formula) | ||
| .select(&:keg_only?) |
There was a problem hiding this comment.
Perhaps controversial idea: I think this could be usefully done for all formulae, not just keg-only. We've debated for a while about whether we should try to support formulae when brew unlinked and, generally, I think we should.
cho-m
force-pushed
the
rewrite-pkgconfig
branch
from
d7266a1
to
b45a7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Concept idea based on manual work in Homebrew/core, e.g.