Early return if Shell#profile's preferred is nil

Homebrew · Jan 22, 2025 · d2fd233 · d2fd233
1 parent 22a1fb9
commit d2fd233
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Library/Homebrew/utils/shell.rb b/Library/Homebrew/utils/shell.rb
@@ -67,7 +67,9 @@ def profile
         return "#{ENV["HOMEBREW_ZDOTDIR"]}/.zshrc" if ENV["HOMEBREW_ZDOTDIR"].present?
       end
 
-      SHELL_PROFILE_MAP.fetch(preferred, "~/.profile")
+      return "~/.profile" if (shell = preferred).nil?
+
+      SHELL_PROFILE_MAP.fetch(shell, "~/.profile")
     end
 
     sig { params(variable: String, value: String).returns(T.nilable(String)) }
@@ -110,7 +112,7 @@ def prepend_path_in_profile(path)
         tcsh: "~/.tcshrc",
         zsh:  "~/.zshrc",
       }.freeze,
-      T::Hash[T.nilable(Symbol), String],
+      T::Hash[Symbol, String],
     )
 
     UNSAFE_SHELL_CHAR = %r{([^A-Za-z0-9_\-.,:/@~+\n])}