Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for review #56

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Request for review #56

wants to merge 9 commits into from

Conversation

atlasianpuns
Copy link

@kahlil29 please review my blog post

@jhrcek
Copy link
Contributor

jhrcek commented Nov 30, 2021

Hello, I don't have any comments regarding the content, just commenting on the structure of this PR:
PRs with blog post source files (e.g. markdown file of the blog post and potentially some images) should target the develop branch, not master

Let us know if you're not confident enough with git, we can help you sort it out.

@turboMaCk
Copy link
Member

I think the problem in this branch is that it rewrites whole history from the commit right after the very first commit. I think first step is to fixup this branch so the history is correct.

@turboMaCk
Copy link
Member

turboMaCk commented Nov 30, 2021

Looking closer to how this work I think the problem is different than what it might seem. Master branch is actually used as deployment by this script https://github.com/Holmusk/holmusk.github.io/blob/develop/scripts/deploy.sh#L8-L18 it creates new git repository every time.

The problem with diff in this PR is because we should never merge to master in this repository. @atlasianpuns can you please change the target to develop branch instead?
image

@atlasianpuns atlasianpuns changed the base branch from master to develop November 30, 2021 17:01
@atlasianpuns
Copy link
Author

@jhrcek @turboMaCk Thanks for informing of the same and sorry for the confusion have modified it. 😄

@jhrcek
Copy link
Contributor

jhrcek commented Nov 30, 2021

No problem, thanks for fixing it 👍

@kahlil29 kahlil29 marked this pull request as draft December 1, 2021 05:01
@atlasianpuns
Copy link
Author

@turboMaCk @jhrcek @oishikg @thongpv87 Hey Guys I was hoping you could review my article. Any advice and feedback would be appreciated

---
title: Building a Centralized Annotated Database
author: Punya Modi
description: What is the need to create a centralized annotated database? what advantages can it pose ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: What is the need to create a centralized annotated database? what advantages can it pose ?
description: What is the need to create a centralized annotated database? What advantages can it pose?

I'm not sure if you can say that "something poses advantages"

title: Building a Centralized Annotated Database
author: Punya Modi
description: What is the need to create a centralized annotated database? what advantages can it pose ?
tags: Devops
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tags should probably mention machine learning

@nitinprakash96
Copy link
Member

@atlasianpuns Could you take care of these reviews?

title: Building a Centralized Annotated Database
author: Punya Modi
description: What is the need to create a centralized annotated database? What advantages can it offer?
tags: Machine Learning =
Copy link
Member

@nitinprakash96 nitinprakash96 Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the = at the end?

tags: Machine Learning =
---

# **Value of Creating a Standardized Annotated Database**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# **Value of Creating a Standardized Annotated Database**
# **Value of creating a standardized annotated database**


# FoodDX

FoodDX is a product from Holmusk that is meant to transform the way consumers think and feel about food, it gives real-time feedback on your meals, FoodDX allows users to upload photos of their meal for real-time nutrition scores and food tips. This is enabled via AI food scoring that leverages the companies real world dataset of over 10,000 + images.
Copy link
Member

@nitinprakash96 nitinprakash96 Dec 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FoodDX is a product from Holmusk that is meant to transform the way consumers think and feel about food, it gives real-time feedback on your meals, FoodDX allows users to upload photos of their meal for real-time nutrition scores and food tips. This is enabled via AI food scoring that leverages the companies real world dataset of over 10,000 + images.
FoodDX is a product from Holmusk that is meant to transform the way consumers think and feel about food. It gives real-time feedback on your meals. FoodDX allows users to upload photos of their meal for real-time nutrition scores and food tips. This is enabled via AI food scoring that leverages real world dataset of over 10,000+ images.

A couple of things here:

  • you could add a few more things about fooddx on what it does. Examples at the our solutions section of https://fooddx.com. Preferably as bullet points. Don't add all of it, just a couple of them
  • 10,000 is not a big dataset (which means not that valuable either). It needs to be 100,000+. (We crossed 100,000 in our first 2 weeks of launch itself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants