silence "From Coq" warning #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/rr/silence__from_coq__warning
branch
from
1c80ebf
to
cd3016b
Compare
|
I can't be more specific with the warning category disabling since these categories don't exist in <= 8.20. |
There should be no warning for disabling an unknown warning so why not be specific? |
<!-- ps-id: 835f7fa1-4876-47a8-8863-876c2cb1edef --> Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/rr/silence__from_coq__warning
branch
from
cd3016b
to
4958e65
Compare
|
I think I got confused with |
jdchristensen
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't fix this warning until we bump the minimal version to 8.21 so for now the best we can do is silence it.