Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at Spaces.No.Core recentlly, I realized that the lines
Context {S : OptionSort@{i}}.
and
Private Inductive Game : Type := | opt : forall (L R : Type@{i}) ...
were inadvertently introducing independent universe variables denoted
i
, when the intention was that they be the same variable. As a result,Game
had two universe variables, which were constrained to be equal. The fix is simply to addUniverse i.
before the first line above, to declarei
as a universe variable throughout the section. This is the content of the first commit, which therefore must also changeGame@{i}
toGame
throughout (sinceGame@{i}
is actually referring to two universe variables, since one is in the context). This reduces by one the number of universe variables in most subsequent results as well.The second commit is purely cosmetic, replacing
InSort@{i}
withInSort
, since there is no ambiguity at all now.The third commit moves the inductive type
No_Empty_for_admitted
earlier in the section. For some reason, it depended on six universe variables. Moving it earlier gets rid of five, and putting it inType0
gets rid of the last one. This has a big impact. For example,plus
in Spaces.No.Addtion goes from 157 variables to 88. And the build times slightly improve.Changes similar to those in the first two commits will need to be done in github1759.v in #1773 . I'm happy to rebase that commit and push the fix there once this is merged. (Or if that is merged first, I'll rebase this and push the fix.)