create etc/emacs/run-etags.sh to make argument processing clear #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdchristensen Are you missing a shell script? |
Alizter
reviewed
Sep 18, 2023
jdchristensen
force-pushed
the
etags-script
branch
from
c56256f
to
5933cd8
Compare
Alizter
reviewed
Sep 18, 2023
Alizter
approved these changes
Sep 18, 2023
|
Did you check both make and dune agree btw? |
|
Yes, they agree, modulo sorting (since the .v files get passed in in a different order). |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Alizter Let me know what you think about this approach. I think it's very easy to understand what is going on if it needs to be updated in the future.