Fix instance cycle in Homotopy.HSpace.Core #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if we had a tool in Coq that could analyse hint databases and determine if there are cycles. If only I had lots of free time. |
Alizter
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd previously (inadvertently) created an instance cycle in
Homotopy.HSpace.Coreby making bothishomogeneous_hspaceandishspace_homogeneousinstances. By making one of these a definition we avoid the cycle. I opted to make the passage from a left-invertible H-space to a homogeneous structure an instance because it forgets data. We could make the other direction aHint Immediate(or something similar), but there's currently nothing that would benefit from it.