Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance cycle in Homotopy.HSpace.Core #1747

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

jarlg
Copy link
Collaborator

@jarlg jarlg commented Sep 3, 2023

I'd previously (inadvertently) created an instance cycle in Homotopy.HSpace.Core by making both ishomogeneous_hspace and ishspace_homogeneous instances. By making one of these a definition we avoid the cycle. I opted to make the passage from a left-invertible H-space to a homogeneous structure an instance because it forgets data. We could make the other direction a Hint Immediate (or something similar), but there's currently nothing that would benefit from it.

@Alizter
Copy link
Collaborator

Alizter commented Sep 3, 2023

It would be nice if we had a tool in Coq that could analyse hint databases and determine if there are cycles. If only I had lots of free time.

@jdchristensen jdchristensen merged commit 138d568 into HoTT:master Sep 3, 2023
23 checks passed
@jarlg jarlg deleted the hspace-instances branch September 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants