Merge pull request #203 from xjodoin/patch-1

Use built-in 'open' method for file object

drf_extra_fields/fields.py

@@ -111,7 +111,7 @@ def to_representation(self, file):
                 return ""
 
             try:
-                with open(file.path, "rb") as f:
+                with file.open() as f:
                     return base64.b64encode(f.read()).decode()
             except Exception:
                 raise OSError("Error encoding file")

tests/test_fields.py

@@ -44,6 +44,9 @@ class ImageFieldFile:
         def __init__(self, path):
             self.path = path
 
+        def open(self):
+            return open(self.path, "rb")
+
     def __init__(self, image_path):
         self.image = self.ImageFieldFile(path=image_path)
 
@@ -53,6 +56,9 @@ class FieldFile:
         def __init__(self, path):
             self.path = path
 
+        def open(self):
+            return open(self.path, "rb")
+
     def __init__(self, file_path):
         self.file = self.FieldFile(path=file_path)