Fix crash on requests that returns an error #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhavens
approved these changes
Oct 14, 2016
andrewhavens
approved these changes
Nov 8, 2016
rafaeliga
force-pushed
the
request-errors-fix
branch
from
8549d48
to
d0f1df2
Compare
|
@andrewhavens just rebased with current master and pushed to my branch, Im not sure if I still need to do something else to see if the Travis build will pass. thanks! |
|
@andrewhavens Travis build have passed! :) |
|
I'm going to merge this since it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should fix issue #44