-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce functionality for chunking and breaking IID experiments #20
Draft
mcw92
wants to merge
35
commits into
main
Choose a base branch
from
feature/breaking_iid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… different train functions
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 75.30% 77.79% +2.48%
==========================================
Files 9 10 +1
Lines 972 1090 +118
==========================================
+ Hits 732 848 +116
- Misses 240 242 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces functionality for the chunking and breaking IID experiments. In particular, the evaluation has been extended to calculate and save local and global confusion matrices in order to enable calculation of arbitrary metrics for the breaking IID experiments.
The following changes have been made:
generate_and_distribute_synthetic_dataset
without local or global imbalances equals the completely balanced dataset generated withmake_classification_dataset
when using the same random state. This ensures comparability of the strong scaling experiment series with and without chunking as the same datasets are created when passing the same random state.train_parallel_on_synthetic data
andtrain_parallel_on_balanced_synthetic_data
. This was completely missing in the former case. In addition, the argument parser was lacking some of the keyword arguments used insklearn
'smake_classification
andtrain_test_split
used under the hood.train
module intotrain_serial
andtrain_parallel
.Notes to self:
sklearn
'sRandomForestClassifier
internally uses weighted voting in itspredict()
method, i.e., the predicted class of an input sample is a vote by the trees in the forest, weighted by their probability estimates. The predicted class thus is the one with highest mean probability estimate across the trees. As theDistributedRandomForest
class inspecialcouscous
only implements plain voting, I also implemented plain voting for calculation of the local confusion matrices instead of usingpredict()
in order to ensure consistency and comparability.