WIP Support installing pyGinkgo via pip #86
Conversation
| - name: Set up Python | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: '3.8' |
There was a problem hiding this comment.
maybe you can take a look on https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations
I think we need to publish several python version?
There was a problem hiding this comment.
true, but this is just for testing. I was a bit reluctant to add more versions here since a single build takes already 40minutes. i fear that we might run out of ci credits.
There was a problem hiding this comment.
I see. When we open source this repo, github action will give unlimited credits for ci
This is how I understand it: pip just invokes cmake with some flags, thus it will run the AutoEnableDevice.cmake which checks if CUDA/HIP is present. This can be also overwritten by https://tttapa.github.io/py-build-cmake/reference/command-line-overrides.html and https://tttapa.github.io/py-build-cmake/reference/config.html#cmake |
| include = ["CMakeLists.txt", "src", "cmake/*", "tests"] | ||
|
|
||
| [tool.py-build-cmake.cmake] | ||
| minimum_version="3.20" |
There was a problem hiding this comment.
| minimum_version="3.20" | |
| minimum_version="3.21" |
Is there any reason for 3.20?
When using ginkgo hip, we require 3.21.
Maybe for simplicity, we use 3.21 here?
| - Pybind11 | ||
| - Ninja # if you want to use cmake presets | ||
| - [pybind11-stubgen](https://pypi.org/project/pybind11-stubgen/) # if you want to use [stubs generation](#stubs-generation) | ||
|
|
||
| ### Building the module | ||
| ### Building the module via Cmake |
There was a problem hiding this comment.
| ### Building the module via Cmake | |
| ### Building the module via CMake |
| @@ -21,12 +21,12 @@ The tests successfully run on the following Python versions: | |||
| ### Prerequisites | |||
|
|
|||
| - Python 3.x | |||
There was a problem hiding this comment.
| - Python 3.x | |
| - Python 3.8+ |
| name = "pyGinkgo" | ||
|
|
||
| [tool.py-build-cmake.sdist] | ||
| include = ["CMakeLists.txt", "src", "cmake/*", "tests"] |
There was a problem hiding this comment.
| include = ["CMakeLists.txt", "src", "cmake/*", "tests"] | |
| include = ["CMakeLists.txt", "src", "cmake/*", "tests", "CTestConfig.cmake"] |
Description
This PR adds an installation routine via pip, which is probably the required prerequisite to get pyGinkgo on to PyPi. It uses https://tttapa.github.io/py-build-cmake/index.html to trigger the cmake build.
It is now possible to build and install pyGinkgo with
pip installorpython -m buildfrom source, also this should be a necessary step towards adding pyGinkgo to PyPi.