Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub for exceptions debugger on large arrays #22

Open
wants to merge 22 commits into
base: protocol_v1.1
Choose a base branch
from

Conversation

imcasper
Copy link

@imcasper imcasper commented Nov 5, 2018

No description provided.

tanis2000 and others added 22 commits January 31, 2016 14:12
… of classes. It seems to work fine on Mac and Windows, too.

Added back the check on the number of classes being sent over the wire to make sure this still works fine with IntelliJ (need someone to test it)
Changes to handle big projects.  Advances client/server protocol version to v1.2.
…t is possible to use HaxeServer with another controllers
…eturning false. 2. Fixed static fields printing: Reflect.getProperty should be on class to get static field.
Stub for exceptions in debugger on large arrays
@EricBishton
Copy link
Member

So, what is your reason for doing this? What are you trying to accomplish? Where do you expect these changes to be used?

I'm asking because you've updated the protocol_v1.1 branch -- to a newer protocol version. We can't do that; it's effectively a frozen branch, and updating it MUST NOT change the protocol in any way. Only bug fixes are allowed there.

IntelliJ IDEA requires the 1.1 version - using the protocol_v1.1 branch.
Visual Studio requires the 1.2 version - using the master branch. (Not sure about VsCode.)
(What version does HaxeDevelop use, I wonder?)

It looks to me that this will change the format of the data coming through the protocol, which means that we need to bump this to a 1.3 version, which also requires changing the rendezvous strings as well as the reported version number.

(I can always create a protocol_v1.2 branch from the master before your changes to support Visual Studio.)

@imcasper
Copy link
Author

It seems I'm confused in the branches. I want to make a view restriction just for an array. Because it leads to crash of the debugger (Inteliji Idea, protocol v 1.1). In any case, it seems strange to me that a debugger crash 300 entries in the array. In general, the debugger often crash, but I did not have time to find other reasons. Crash -- I mean critical uncaught exception (in debugger) and program stop.

@imcasper
Copy link
Author

#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants