Zoras River Refactor #127
Open
Zoras River Refactor #127
+70
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattman107
commented
Jan 21, 2026
Author
mattman107
left a comment
mattman107
left a comment
There was a problem hiding this comment.
Some weird bits that I marked down.
Comment on lines
+158
to
+161
| add_events(Regions.ZR_PILLAR, world, [ | ||
| # This needs some extra logic because this grass needs to be accessible from multiple other regions, but the bugs they actually have to get here. | ||
| # The boomerang check doesn't get the bugs from Zora's River -> Pillar | ||
| (EventLocations.ZR_BUG_GRASS, Events.CAN_ACCESS_BUGS, lambda bundle: can_cut_shrubs(bundle) and ((is_child(bundle) and has_item(Items.POWER_BRACELET, bundle)) or can_use(Items.HOVER_BOOTS, bundle) or (is_adult(bundle) and can_do_trick(Tricks.ZR_LOWER, bundle)))), |
Author
There was a problem hiding this comment.
This was probably the worst part. Essentially the logic for the grass needs it to be accessible from both Regions.ZORAS_RIVER and Regions.ZR_PILLAR. I tried to keep it as intact as possible, but this event required some duplicate logic to determine if the player could actually reach the grass to scoop up the bugs.
| (Regions.ZR_FAIRY_GROTTO, lambda bundle: blast_or_smash(bundle)), | ||
| (Regions.ZR_ATOP_LADDER, lambda bundle: (is_adult(bundle) or has_item(Items.POWER_BRACELET, bundle)) and (has_item(Items.CLIMB, bundle) or (is_adult(bundle) and can_use(Items.HOOKSHOT, bundle)) or has_item(LocalEvents.ZR_BEAN_PLANTED, bundle))), | ||
| # Added Boomerang check here for accessing the pillar logically with just the boomerang. It can get the Freestanding POH and Grass | ||
| (Regions.ZR_PILLAR, lambda bundle: (is_child(bundle) and has_item(Items.POWER_BRACELET, bundle)) or can_use(Items.HOVER_BOOTS, bundle) or (is_adult(bundle) and can_do_trick(Tricks.ZR_LOWER, bundle)) or can_use(Items.BOOMERANG, bundle)), |
Author
There was a problem hiding this comment.
The Boomerang check at the end here is to allow access to both locations in Regions.ZR_PILLAR. It gets wonky with the bug event though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.