Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in hs.dialog #3575

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

latenitefilms
Copy link
Contributor

  • Replaced setAllowedFileTypes with setAllowedContentTypes.

- Replaced `setAllowedFileTypes` with `setAllowedContentTypes`.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['pr-fix', 'pr-change', 'pr-feature', 'pr-maintenance']

@latenitefilms latenitefilms marked this pull request as draft December 28, 2023 23:51
@latenitefilms
Copy link
Contributor Author

@cmsj - For some reason I can't set you as a reviewer in GitHub?

@latenitefilms latenitefilms marked this pull request as ready for review December 28, 2023 23:52
Copy link

View Test Results

2 tests   2 ✔️  0s ⏱️
2 suites  0 💤
1 files    0

Results for commit 353c7a7.

@latenitefilms latenitefilms marked this pull request as draft January 18, 2024 21:20
@latenitefilms
Copy link
Contributor Author

Need to fix this before merging:

ERROR:   LuaSkin: hs.webview.usercontent callback: NSInvalidArgumentException: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil
(
	0   CoreFoundation                      0x000000018c22c570 __exceptionPreprocess + 176
	1   libobjc.A.dylib                     0x000000018bd1deb4 objc_exception_throw + 60
	2   CoreFoundation                      0x000000018c158584 -[__NSArrayM insertObject:atIndex:] + 1284
	3   libdialog.dylib                     0x0000000106fe1e10 chooseFileOrFolder + 292
	4   LuaSkin                             0x0000000104e732dc precallC + 132
	5   LuaSkin                             0x0000000104e734dc luaD_precall + 328
	6   LuaSkin                             0x0000000104e69f98 luaV_execute + 16536
	7   LuaSkin                             0x0000000104e73628 luaD_callnoyield + 96
	8   LuaSkin                             0x0000000104e5d728 luai_objcttry + 48
	9   LuaSkin                             0x0000000104e73bf4 luaD_pcall + 92
	10  LuaSkin                             0x0000000104e7851c lua_pcallk + 368
	11  LuaSkin                             0x0000000104e54004 -[LuaSkin protectedCallAndTraceback:nresults:] + 200
	12  LuaSkin                             0x0000000104e54094 -[LuaSkin protectedCallAndError:nargs:nresults:] + 60
	13  libwebviewusercontent.dylib         0x00000001071b6078 -[HSUserContentController userContentController:didReceiveScriptMessage:] + 248
	14  WebKit                              0x00000001af00cea0 _ZN28ScriptMessageHandlerDelegate14didPostMessageERN6WebKit12WebPageProxyEONS0_13FrameInfoDataERN3API12ContentWorldERN7WebCore21SerializedScriptValueE + 228
	15  WebKit                              0x00000001af4335d4 _ZN6WebKit29WebUserContentControllerProxy14didPostMessageEN3WTF23ObjectIdentifierGenericINS_26WebPageProxyIdentifierTypeENS1_38ObjectIdentifierMainThreadAccessTraitsEEEONS_13FrameInfoDataEyRKNSt3__14spanIKhLm18446744073709551615EEEONS1_17CompletionHandlerIFvOSB_RKNS1_6StringEEEE + 680
	16  WebKit                              0x00000001af7d1448 _ZN6WebKit29WebUserContentControllerProxy17didReceiveMessageERN3IPC10ConnectionERNS1_7DecoderE + 356
	17  WebKit                              0x00000001af7ea15c _ZN3IPC18MessageReceiverMap15dispatchMessageERNS_10ConnectionERNS_7DecoderE + 264
	18  WebKit                              0x00000001af39c50c _ZN6WebKit15WebProcessProxy17didReceiveMessageERN3IPC10ConnectionERNS1_7DecoderE + 40
	19  WebKit                              0x00000001af7e50e4 _ZN3IPC10Connection15dispatchMessageENSt3__110unique_ptrINS_7DecoderENS1_14default_deleteIS3_EEEE + 324
	20  WebKit                              0x00000001af7e5530 _ZN3IPC10Connection24dispatchIncomingMessagesEv + 496
	21  JavaScriptCore                      0x00000001a7fc9ad8 _ZN3WTF7RunLoop11performWorkEv + 204
	22  JavaScriptCore                      0x00000001a7fca9a8 _ZN3WTF7RunLoop11performWorkEPv + 36
	23  CoreFoundation                      0x000000018c1b7a4c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
	24  CoreFoundation                      0x000000018c1b79e0 __CFRunLoopDoSource0 + 176
	25  CoreFoundation                      0x000000018c1b7750 __CFRunLoopDoSources0 + 244
	26  CoreFoundation                      0x000000018c1b6340 __CFRunLoopRun + 828
	27  CoreFoundation                      0x000000018c1b59ac CFRunLoopRunSpecific + 608
	28  HIToolbox                           0x0000000196764448 RunCurrentEventLoopInMode + 292
	29  HIToolbox                           0x00000001967640d8 ReceiveNextEventCommon + 220
	30  HIToolbox                           0x0000000196763fdc _BlockUntilNextEventMatchingListInModeWithFilter + 76
	31  AppKit                              0x000000018f9928a4 _DPSNextEvent + 660
	32  AppKit                              0x000000019016c980 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 716
	33  AppKit                              0x000000018f985d50 -[NSApplication run] + 476
	34  AppKit                              0x000000018f95d014 NSApplicationMain + 880
	35  dyld                                0x000000018bd590e0 start + 2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant