Standardize Buttons #15330
Draft
Standardize Buttons #15330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tressley
reviewed
Oct 14, 2024
| height: 32px; | ||
| margin-top: 16px; | ||
| padding: 2px 12px; | ||
| line-height: 24px; |
There was a problem hiding this comment.
Why use px for line-height?
Tressley
reviewed
Oct 14, 2024
| border-radius: 4px; | ||
| box-shadow: 0 1px 3px 0 rgba($black, 0.12), 0 1px 2px 0 rgba($black, 0.24); | ||
| color: $white; | ||
|
|
||
| &:hover, &:focus { | ||
| box-shadow: 0 3px 6px 0 rgba($black, 0.16), 0 3px 6px 0 rgba($black, 0.24); | ||
| box-shadow: 0px 3px 6px 0px rgba(26, 24, 29, 0.16), 0px 3px 6px 0px rgba(26, 24, 29, 0.24); |
There was a problem hiding this comment.
No need to use units when the value is 0. We should also aim to be consistent across the code base. If you look above at line 10, you'll see that 0 does not have a unit and the box-shadow property is using the $black variable which is the same as rgb(26, 24, 29).
Tressley
reviewed
Oct 14, 2024
Tressley
reviewed
Oct 29, 2024
|
|
||
| --icon-color: #{$white}; | ||
| } | ||
|
|
||
| &:active:focus, &.active:focus { | ||
| box-shadow: none; | ||
| border-color: $purple-400; | ||
| border: 2px solid $purple-200; |
There was a problem hiding this comment.
This should be purple-400?
Tressley
reviewed
Oct 29, 2024
| } | ||
|
|
||
| &:focus { | ||
| background: $maroon-100; | ||
| border-color: $purple-400; | ||
| border: 2px solid $purple-200; |
There was a problem hiding this comment.
This should also be purple-400.
Tressley
reviewed
Oct 29, 2024
| } | ||
|
|
||
| &:not(:disabled):not(.disabled):active:focus, &:not(:disabled):not(.disabled).active:focus { | ||
| box-shadow: none; | ||
| border-color: $purple-400; | ||
| border: 2px solid $purple-200; |
There was a problem hiding this comment.
purple-400 here as well.
Tressley
reviewed
Oct 29, 2024
| color: $white; | ||
| } | ||
|
|
||
| &:focus { | ||
| background: $orange-10; | ||
| border-color: $purple-400; | ||
| border: 2px solid $purple-200; |
Tressley
reviewed
Oct 29, 2024
| } | ||
|
|
||
| &:not(:disabled):not(.disabled):active:focus, &:not(:disabled):not(.disabled).active:focus { | ||
| border: 2px solid $purple-200; |
Tressley
reviewed
Oct 29, 2024
| } | ||
|
|
||
| &:focus { | ||
| background: $green-50; | ||
| border-color: $purple-400; | ||
| border: 2px solid $purple-200; |
* begin removing obsolete tests * begin refactoring * update cron tests * cleanup * finish basic implementation of new logic * add more subscription tests * subscription test improvements * return nextHourglassDate again * fix gem limit * fix(test): short circuit this. * fix(admin): correct logic and style for shrimple subs * WIP(frontend): draft of main subs page view * fix hourglass count * Fix hourglass logic for upgrades * fix admin panel display * WIP(subs): extant Stripe state * fix admin panel strings * fix missing transaction type * add new field for cumulative subscription count * show date for hourglass bonus if it was received * fix test * feat(subscription): max Gems progress readout * fix(css): correct and refactor heights and selection states * fix(subs): correct border-radius and redirect * fix(stripe): correct redirect after success * Admin panel display fixes * don’t give additional HG for new sub if they already got one this month * fix issue with promo hourglasses * fix(subscription): update layout when gifting * fix(subscriptions): more gift layout revisions * fix(subscriptions): minor visual updates * fix(subs): pass autoRenews through Stripe * fix(subs): gifts DON't renew * fix(lint): unnecessary ternary * fix(lint): do negate object ig * fix(subs): try again on gifts * fix(subs): unhovery and un-12-monthy * fix bug with incorrectly giving HG bonus * remove only * fix test * fix test * fix(subs): also redirect to subs after gift sub * fix(subs): fix typeError * fix(g1g1): don't try to find Gems promo during bogo --------- Co-authored-by: Phillip Thelen <[email protected]> Co-authored-by: Kalista Payne <[email protected]>
* begin removing obsolete tests * begin refactoring * update cron tests * cleanup * finish basic implementation of new logic * add more subscription tests * subscription test improvements * return nextHourglassDate again * fix gem limit * fix(test): short circuit this. * fix(admin): correct logic and style for shrimple subs * WIP(frontend): draft of main subs page view * fix hourglass count * Fix hourglass logic for upgrades * fix admin panel display * WIP(subs): extant Stripe state * fix admin panel strings * fix missing transaction type * add new field for cumulative subscription count * show date for hourglass bonus if it was received * fix test * feat(subscription): max Gems progress readout * fix(css): correct and refactor heights and selection states * fix(subs): correct border-radius and redirect * fix(stripe): correct redirect after success * Admin panel display fixes * don’t give additional HG for new sub if they already got one this month * fix issue with promo hourglasses * fix(subscription): update layout when gifting * fix(subscriptions): more gift layout revisions * fix(subscriptions): minor visual updates * fix(subs): pass autoRenews through Stripe * fix(subs): gifts DON't renew * fix(lint): unnecessary ternary * fix(lint): do negate object ig * fix(subs): try again on gifts * fix(subs): unhovery and un-12-monthy * fix bug with incorrectly giving HG bonus * remove only * fix test * fix test * fix(subs): also redirect to subs after gift sub * fix(subs): fix typeError * fix(g1g1): don't try to find Gems promo during bogo --------- Co-authored-by: Phillip Thelen <[email protected]> Co-authored-by: Kalista Payne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.