feat(faq): update questions and answers

package.json

@@ -1,7 +1,7 @@
 {
   "name": "habitica",
   "description": "A habit tracker app which treats your goals like a Role Playing Game.",
-  "version": "5.9.1",
+  "version": "5.10.0",
   "main": "./website/server/index.js",
   "dependencies": {
     "@babel/core": "^7.22.10",

test/api/v3/integration/challenges/POST-challenge_flag.test.js

@@ -0,0 +1,62 @@
+import { v4 as generateUUID } from 'uuid';
+import {
+  generateChallenge,
+  createAndPopulateGroup,
+  translate as t,
+} from '../../../../helpers/api-integration/v3';
+
+describe('POST /challenges/:challengeId/flag', () => {
+  let user;
+  let challenge;
+
+  beforeEach(async () => {
+    const { group, groupLeader } = await createAndPopulateGroup({
+      groupDetails: {
+        name: 'TestParty',
+        type: 'party',
+        privacy: 'private',
+      },
+      members: 1,
+    });
+
+    user = groupLeader;
+
+    challenge = await generateChallenge(user, group);
+  });
+
+  it('returns an error when challenge is not found', async () => {
+    await expect(user.post(`/challenges/${generateUUID()}/flag`))
+      .to.eventually.be.rejected.and.eql({
+        code: 404,
+        error: 'NotFound',
+        message: t('challengeNotFound'),
+      });
+  });
+
+  it('flags a challenge', async () => {
+    const flagResult = await user.post(`/challenges/${challenge._id}/flag`);
+
+    expect(flagResult.challenge.flags[user._id]).to.equal(true);
+    expect(flagResult.challenge.flagCount).to.equal(1);
+  });
+
+  it('flags a challenge with a higher count when from an admin', async () => {
+    await user.update({ 'contributor.admin': true });
+
+    const flagResult = await user.post(`/challenges/${challenge._id}/flag`);
+
+    expect(flagResult.challenge.flags[user._id]).to.equal(true);
+    expect(flagResult.challenge.flagCount).to.equal(5);
+  });
+
+  it('returns an error when user tries to flag a challenge that is already flagged', async () => {
+    await user.post(`/challenges/${challenge._id}/flag`);
+
+    await expect(user.post(`/challenges/${challenge._id}/flag`))
+      .to.eventually.be.rejected.and.eql({
+        code: 404,
+        error: 'NotFound',
+        message: t('messageChallengeFlagAlreadyReported'),
+      });
+  });
+});

test/api/v3/integration/challenges/POST-challenge_flag_clear.test.js

@@ -0,0 +1,58 @@
+import { v4 as generateUUID } from 'uuid';
+import {
+  generateChallenge,
+  createAndPopulateGroup,
+  translate as t,
+} from '../../../../helpers/api-integration/v3';
+
+describe('POST /challenges/:challengeId/clearflags', () => {
+  let admin;
+  let nonAdmin;
+  let challenge;
+
+  beforeEach(async () => {
+    const { group, groupLeader, members } = await createAndPopulateGroup({
+      groupDetails: {
+        name: 'TestParty',
+        type: 'party',
+        privacy: 'private',
+      },
+      members: 1,
+    });
+
+    admin = groupLeader;
+    [nonAdmin] = members;
+
+    await admin.update({ 'permissions.moderator': true });
+
+    challenge = await generateChallenge(admin, group);
+    await admin.post(`/challenges/${challenge._id}/flag`);
+  });
+
+  it('returns error when non-admin attempts to clear flags', async () => {
+    await expect(nonAdmin.post(`/challenges/${generateUUID()}/clearflags`))
+      .to.eventually.be.rejected.and.eql({
+        code: 401,
+        error: 'NotAuthorized',
+        message: t('messageGroupChatAdminClearFlagCount'),
+      });
+  });
+
+  it('returns an error when challenge is not found', async () => {
+    await expect(admin.post(`/challenges/${generateUUID()}/clearflags`))
+      .to.eventually.be.rejected.and.eql({
+        code: 404,
+        error: 'NotFound',
+        message: t('challengeNotFound'),
+      });
+  });
+
+  it('clears flags and sets mod flag to false', async () => {
+    await nonAdmin.post(`/challenges/${challenge._id}/flag`);
+    const flagResult = await admin.post(`/challenges/${challenge._id}/clearflags`);
+
+    expect(flagResult.challenge.flagCount).to.eql(0);
+    expect(flagResult.challenge.flags).to.have.property(admin._id, false);
+    expect(flagResult.challenge.flags).to.have.property(nonAdmin._id, true);
+  });
+});

test/api/v4/faq/GET-faq.test.js

@@ -12,7 +12,7 @@ describe('GET /faq', () => {
       expect(res).to.have.property('stillNeedHelp');
       expect(res.stillNeedHelp.ios).to.equal(translate('iosFaqStillNeedHelp'));
       expect(res).to.have.property('questions');
-      expect(res.questions[0].question).to.equal(translate('faqQuestion0'));
+      expect(res.questions[0].question).to.equal(translate('faqQuestion25'));
     });
 
     it('returns faq not in English', async () => {
@@ -29,20 +29,6 @@ describe('GET /faq', () => {
   });
 
   describe('platform parameter', () => {
-    it('returns faq with answers for ios platform only', async () => {
-      const res = await requester().get('/faq?platform=ios');
-
-      expect(res).to.have.property('stillNeedHelp');
-      expect(res.stillNeedHelp).to.eql({ ios: translate('iosFaqStillNeedHelp') });
-
-      expect(res).to.have.property('questions');
-      expect(res.questions[0]).to.eql({
-        exclusions: [],
-        heading: 'overview',
-        question: translate('faqQuestion0'),
-        ios: translate('iosFaqAnswer0'),
-      });
-    });
     it('returns an error when invalid platform parameter is specified', async () => {
       const request = requester().get('/faq?platform=wrong');
       await expect(request)
@@ -52,18 +38,5 @@ describe('GET /faq', () => {
           message: i18n.t('invalidReqParams'),
         });
     });
-    it('falls back to "web" description if there is no description for specified platform', async () => {
-      const res = await requester().get('/faq?platform=android');
-      expect(res).to.have.property('stillNeedHelp');
-      expect(res.stillNeedHelp).to.eql({ web: translate('webFaqStillNeedHelp') });
-
-      expect(res).to.have.property('questions');
-      expect(res.questions[0]).to.eql({
-        exclusions: [],
-        heading: 'overview',
-        question: translate('faqQuestion0'),
-        android: translate('androidFaqAnswer0'),
-      });
-    });
   });
 });

test/content/faq.js

@@ -15,12 +15,6 @@ describe('FAQ Locales', () => {
       });
     });
 
-    it('has a valid ios answers', () => {
-      each(questions, question => {
-        expectValidTranslationString(question.ios);
-      });
-    });
-
     it('has a valid web answers', () => {
       each(questions, question => {
         expectValidTranslationString(question.web);
@@ -29,10 +23,6 @@ describe('FAQ Locales', () => {
   });
 
   describe('Still Need Help Message', () => {
-    it('has a valid ios message', () => {
-      expectValidTranslationString(stillNeedHelp.ios);
-    });
-
     it('has a valid web message', () => {
       expectValidTranslationString(stillNeedHelp.web);
     });