-
Notifications
You must be signed in to change notification settings - Fork 0
Get hasura user id and save it to changed_by #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Jontzii
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jontzii reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @suvikankare).
src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 229 at r1 (raw file):
}); }
Sinänsä nää turhat sisennykset olisi hyvä varmaan poistaa täältä välistä, mutta en sen takia rupea hylkäämään
src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 370 at r1 (raw file):
return true; }
Sama tässä
|
Previously, Jontzii (Joonas Hiltunen) wrote…
Okei tossa kommentista ei nyt näkynytkään tää oikein mut reviewablessa näkyy punasina pisteinä |
c08a9ce to
7e7019d
Compare
culka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@culka reviewed all commit messages and made 3 comments.
Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @Jontzii and @suvikankare).
src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 428 at r3 (raw file):
// Clean empty alternative names if (stopPlace.getAlternativeNames() != null) { stopPlace.getAlternativeNames().removeIf(altName ->
Tässä ja kahdella seuraavalla rivillä on ylimääräinen välilyönti lopussa.
src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 438 at r3 (raw file):
// Clean empty keyValues entries if (stopPlace.getKeyValues() != null) { stopPlace.getKeyValues().entrySet().removeIf(entry ->
Tässä ja kahdella seuraavalla sama homma myös
7e7019d to
8e74cac
Compare
suvikankare
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suvikankare resolved 4 discussions.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Jontzii).
This change is