Skip to content

Conversation

@suvikankare
Copy link
Member

@suvikankare suvikankare commented Jan 15, 2026

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@suvikankare suvikankare changed the title Hasura user Get hasura user id and save it to changed_by Jan 15, 2026
@suvikankare suvikankare marked this pull request as ready for review January 16, 2026 07:55
Copy link
Member

@Jontzii Jontzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Jontzii reviewed 2 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @suvikankare).


src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 229 at r1 (raw file):

            });
        }
        

Sinänsä nää turhat sisennykset olisi hyvä varmaan poistaa täältä välistä, mutta en sen takia rupea hylkäämään


src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 370 at r1 (raw file):

            return true;
        }
        

Sama tässä

@Jontzii
Copy link
Member

Jontzii commented Jan 16, 2026

src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 229 at r1 (raw file):

Previously, Jontzii (Joonas Hiltunen) wrote…

Sinänsä nää turhat sisennykset olisi hyvä varmaan poistaa täältä välistä, mutta en sen takia rupea hylkäämään

Okei tossa kommentista ei nyt näkynytkään tää oikein mut reviewablessa näkyy punasina pisteinä

@suvikankare suvikankare force-pushed the hasura-user-id branch 6 times, most recently from c08a9ce to 7e7019d Compare January 19, 2026 12:33
Copy link

@culka culka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@culka reviewed all commit messages and made 3 comments.
Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @Jontzii and @suvikankare).


src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 428 at r3 (raw file):

        // Clean empty alternative names
        if (stopPlace.getAlternativeNames() != null) {
            stopPlace.getAlternativeNames().removeIf(altName -> 

Tässä ja kahdella seuraavalla rivillä on ylimääräinen välilyönti lopussa.


src/main/java/org/rutebanken/tiamat/versioning/save/StopPlaceVersionedSaverService.java line 438 at r3 (raw file):

        // Clean empty keyValues entries
        if (stopPlace.getKeyValues() != null) {
            stopPlace.getKeyValues().entrySet().removeIf(entry -> 

Tässä ja kahdella seuraavalla sama homma myös

Copy link
Member Author

@suvikankare suvikankare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suvikankare resolved 4 discussions.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @Jontzii).

@suvikankare suvikankare merged commit 220326c into main Jan 20, 2026
17 of 18 checks passed
@suvikankare suvikankare deleted the hasura-user-id branch January 20, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants