Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #3849] Remove historical transforms from funding category [2/4] #3880

Conversation

mikehgrantsgov
Copy link
Collaborator

Summary

Partially Fixes #3849

Time to review: 10 mins

Changes proposed

Modify funding category transforms and tests to remove legacy history table processing.

Context for reviewers

This is PR 2/4. Subsequent types to come.

Additional information

See updated to tests

@mikehgrantsgov mikehgrantsgov marked this pull request as ready for review February 13, 2025 20:27
Base automatically changed from mikehgrantsgov/3849-remove-historical-transforms-app-type to main February 14, 2025 16:02
@chouinar
Copy link
Collaborator

@mikehgrantsgov - I think you want to resync this one with main as it has some of the changes you already made in it

@mikehgrantsgov
Copy link
Collaborator Author

@mikehgrantsgov - I think you want to resync this one with main as it has some of the changes you already made in it

Yeah should only be 2 changed files, good catch.

Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikehgrantsgov mikehgrantsgov merged commit 06d519c into main Feb 14, 2025
2 checks passed
@mikehgrantsgov mikehgrantsgov deleted the mikehgrantsgov/3849-remove-historical-transforms-funding-category branch February 14, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove transformations from legacy history tables to our non-history tables
2 participants