[Issue #3050] Make sure we escape single quotes #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
previously approved these changes
Nov 26, 2024
|
Linter is failing though |
mdragon
force-pushed
the
mdragon/3050-incorrect-string-escaping
branch
from
f9ac6f6
to
f77fffe
Compare
Nice catch, amended the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3050
Time to review: 2 mins
Changes proposed
Make sure we're escaping single quotes in our DB strings
Context for reviewers
Tests started failing due to a string with "children's" in it
All tests are now passing locally