[no ticket] Use higher ASG targets #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At 50% memory, the frontend hits that memory cap easily and immediately gets cycled out. I wasn't really expecting this behavior, but you live and you learn.
Changes proposed
Increases the memory target to 99%, so nextjs only spins up new containers when after containers max out their cache. This won't meaningfully impact the backend, because the because the backend doesn't have an infinitely* scaling cache.
* There's not significant indication that the nextjs cache is infinitely scaling. It might just scale higher than our current memory numbers.
I also increased the CPU target to 75%, which may come back to bite me I dunno. We'll see.