[Issue #2810] Connect all the components of the /users/token endpoint together #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouinar
commented
Nov 22, 2024
| def override_method(config): | ||
| config.public_keys = [public_rsa_key] | ||
|
|
||
| monkeypatch_session.setattr(login_gov_jwt_auth, "_refresh_keys", override_method) |
There was a problem hiding this comment.
Note for self - what if I instead made a dummy endpoint that returned the keys? That would at least validate the parsing logic
chouinar
commented
Nov 22, 2024
| @@ -41,7 +41,7 @@ LOG_ENABLE_AUDIT=FALSE | |||
| # The auth token used by the local endpoints | |||
| API_AUTH_TOKEN=LOCAL_AUTH_12345678,LOCAL_AUTH_87654321,LOCAL_1234 | |||
|
|
|||
| LOGIN_GOV_JWK_ENDPOINT=http://localhost:5001/issuer1/jwks | |||
| LOGIN_GOV_JWK_ENDPOINT=http://mock-oauth2-server:5001/issuer1/jwks | |||
There was a problem hiding this comment.
I should look into defining this different in some way? Got a weird email directly from GitHub complaining about:
GitGuardian has detected the following Generic High Entropy Secret exposed within your GitHub account.
I can mark as a false positive, but maybe this is a problem for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: Needs a bit more testing/cleanup, but I'll be out next week, so getting any feedback folks might have up front.
TODO for when I get back:
Summary
Fixes #2810
Time to review: 15 mins
Changes proposed
Connected all the components of the /users/token endpoint that had been built out separately:
Context for reviewers
TODO
Additional information
TODO