Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wired up agreements #850

Merged
merged 1 commit into from
Apr 12, 2023
Merged

wired up agreements #850

merged 1 commit into from
Apr 12, 2023

Conversation

tdonaworth
Copy link
Contributor

What changed

  • Updated AgreementSelect to use only a uswds-select instead of combobox
  • updated the getAgreementsByResearchId api call
  • refactored the ProjectSelect and CreateBudgetLine components.

Issue

#818

How to test

Unit Tests - TODO: update E2@

Screenshots

image

fpigeonjr
fpigeonjr approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@fpigeonjr fpigeonjr merged commit 2ec1013 into OPS-674-BL-FrontEnd Apr 12, 2023
@fpigeonjr fpigeonjr deleted the OPS-818_Wiring_up_Agreements branch April 12, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@johndeange johndeange Awaiting requested review from johndeange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdonaworth @fpigeonjr