Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api integration for summary cards #3157

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Conversation

maiyerlee
Copy link
Contributor

@maiyerlee maiyerlee commented Dec 2, 2024

What changed

Use API data for frontend CAN features.

Issue

2842

How to test

  • E2E and unit tests are passing.
  • Navigate to the CAN List page and select different fiscal years and filters.
    • Ensure CAN list and summary cards are updated accordingly.
  • Go to /cans/504/spending and select FY 2043.
    • Ensure budget lines appear in the table above.
    • Ensure the agreement name and procurement shop abbreviation are displayed properly.
    • Check that summary cards have correct data displayed.

Screenshots

N/A

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
    - [ ] Form validations updated

Links

N/A

Sorry, something went wrong.

@maiyerlee maiyerlee changed the title Can Spending Tab: remove hardcoded in draft budge lines funding CAN API Integration Dec 4, 2024
@maiyerlee maiyerlee marked this pull request as ready for review December 4, 2024 21:57
@maiyerlee maiyerlee changed the title CAN API Integration feat: api integration for summary cards Dec 5, 2024
@maiyerlee maiyerlee merged commit d025186 into main Dec 5, 2024
42 checks passed
@maiyerlee maiyerlee deleted the OPS-2842-can-spending-tab branch December 5, 2024 14:42
Copy link

github-actions bot commented Dec 5, 2024

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants