Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix CreateUpdateCANFundingBudgetRequest example values #3105

Merged

Conversation

maiyerlee
Copy link
Contributor

@maiyerlee maiyerlee commented Nov 19, 2024

What changed

/api/v1/can-funding-budgets/ POST request body is expecting a budget field. Change updates the CreateUpdateCANFundingBudgetRequest example in the openapi file to include budget and remove funding.

Issue

3104

How to test

OpenAPI spec displays correct fields.

Screenshots

N/A

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
    - [ ] 90%+ Code coverage achieved
    - [ ] Form validations updated

Links

N/A

@maiyerlee maiyerlee closed this Nov 19, 2024
@maiyerlee maiyerlee force-pushed the OPS-3104-CreateUpdateCANFundingBudgetRequest-example branch from 5683fc9 to b13b4a4 Compare November 19, 2024 21:45
@maiyerlee maiyerlee reopened this Nov 19, 2024
@maiyerlee maiyerlee self-assigned this Nov 19, 2024
@maiyerlee maiyerlee marked this pull request as ready for review November 19, 2024 21:48
@maiyerlee maiyerlee changed the title doc: fix CreateUpdateCANFundingBudgetRequest values doc: fix CreateUpdateCANFundingBudgetRequest example values Nov 19, 2024
@maiyerlee maiyerlee changed the title doc: fix CreateUpdateCANFundingBudgetRequest example values docs: fix CreateUpdateCANFundingBudgetRequest example values Nov 19, 2024
@maiyerlee maiyerlee merged commit 09df606 into main Nov 20, 2024
81 checks passed
@maiyerlee maiyerlee deleted the OPS-3104-CreateUpdateCANFundingBudgetRequest-example branch November 20, 2024 22:51
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants