Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2907 range slider component #2938

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from
Draft

2907 range slider component #2938

wants to merge 36 commits into from

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 16, 2024 •
edited
Loading

What changed

  • adds CANBudgetRangeSlider

Issue

#347 #2907 #2910

How to test

  1. Goto CANs list
  2. select FY23
  3. filter by budget range
  4. see table update

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

fpigeonjr
fpigeonjr commented Oct 16, 2024
View reviewed changes
frontend/package.json
"sass": "1.77.8",
"sass-loader": "14.2.1",
"styled-components": "6.1.13",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may consider removing this dependency in favor of css modules

@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 16, 2024
maiyerlee and others added 2 commits October 17, 2024 14:26
@maiyerlee @fpigeonjr
wip: fix range text and FY values (#2946)
bbff0d9 
* Fix: don't show range text with no cans

* Fix: use non-changing filtered cans when calculating FY min, max

* feat: no cans no filter

---------

Co-authored-by: Frank Pigeon Jr <[email protected]>
@fpigeonjr
refactor: raises and persists budget state
e1b856d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fpigeonjr fpigeonjr

@maiyerlee maiyerlee

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpigeonjr @maiyerlee