Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: displays CAN obligate_by as MM/DD/YY #2873

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 1, 2024

Issue

#346

How to test

  1. Go to list of cans
  2. see obligate_by as MM/DD/YY

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Oct 1, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 1, 2024
number:
type: string
obligate_by:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added obligate_by and sorted alphebetically

@jonnalley jonnalley changed the title refactor: displays obligate_by as MM/DD/YY refactor: displays CAN obligate_by as MM/DD/YY Oct 1, 2024
@@ -56,67 +57,6 @@ const CANTable = ({ cans }) => {
);
};

const TableHead = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to its own component

@@ -17,13 +15,15 @@ export type CAN = {
id: number;
nick_name?: string;
number: string;
obligate_by?: Date;
obligate_by?: number;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajohnson90 didn't think this was a Date

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't a date. Already covered this on collab but just writing it down so it's documented.

Copy link
Contributor

@johndeange johndeange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR has the off by one error that we discussed the other day, e.g. in the example a 1 year CAN with an appropriation year of 2023 (10/1/2022) should be valid until 9/30/2023 (according to our current business rules). In this case, when the backend returns 2024, the 2024 fiscal year begins 10/1/2023 and so the obligate by should be 9/30/2023.

@fpigeonjr
Copy link
Contributor Author

I think this PR has the off by one error that we discussed the other day, e.g. in the example a 1 year CAN with an appropriation year of 2023 (10/1/2022) should be valid until 9/30/2023 (according to our current business rules). In this case, when the backend returns 2024, the 2024 fiscal year begins 10/1/2023 and so the obligate by should be 9/30/2023.

I was scared of this, thanks John for calling this out.

@fpigeonjr
Copy link
Contributor Author

image

@fpigeonjr fpigeonjr merged commit e00aed2 into main Oct 2, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-346/2872 branch October 2, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants