-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: displays CAN obligate_by as MM/DD/YY #2873
Conversation
number: | ||
type: string | ||
obligate_by: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added obligate_by
and sorted alphebetically
@@ -56,67 +57,6 @@ const CANTable = ({ cans }) => { | |||
); | |||
}; | |||
|
|||
const TableHead = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to its own component
@@ -17,13 +15,15 @@ export type CAN = { | |||
id: number; | |||
nick_name?: string; | |||
number: string; | |||
obligate_by?: Date; | |||
obligate_by?: number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rajohnson90 didn't think this was a Date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't a date. Already covered this on collab but just writing it down so it's documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR has the off by one error that we discussed the other day, e.g. in the example a 1 year CAN with an appropriation year of 2023 (10/1/2022) should be valid until 9/30/2023 (according to our current business rules). In this case, when the backend returns 2024, the 2024 fiscal year begins 10/1/2023 and so the obligate by should be 9/30/2023.
I was scared of this, thanks John for calling this out. |
Issue
#346
How to test
Screenshots
Definition of Done Checklist