Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update remove objectives #352

Merged
merged 44 commits into from
Mar 8, 2021
Merged

Add update remove objectives #352

merged 44 commits into from
Mar 8, 2021

Commits on Feb 16, 2021

  1. Can add objectives to goals

    The frontend can add objects to goals. Uses react-hook-form's
    field array for objectives. I could not find an example where a field
    array was nested without the first array also being a part of the field
    array. Since goals are done with the multiselect I couldn't figure out a
    way to use a field array with goals. I had some issues getting
    everything to work but once I moved the objective's "edit" state outside
    of hook form and into the objective component as state things started to
    simplify a bit.
    
    Waiting for the recent form validation PR to merge before moving this
    forward. Still need to handle error messages and finalize validations.
    jasalisbury committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    0b6728b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    8ec03c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    472dd7d View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    c3b25d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6a2dfe7 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge branch 'main' into js-229-add-update-remove-objectives

    Conflicts:
    	frontend/src/components/MultiSelect.js
    jasalisbury committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    6655bdc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    61f2bc7 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Configuration menu
    Copy the full SHA
    049e8e7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1f02766 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac250d8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    09d60e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Single objective added to every goal if needed

    If a goal has zero objectives one is added. If a goal only has one
    objective that objective cannot be removed.
    jasalisbury committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    72e1d7a View commit details
    Browse the repository at this point in the history
  2. Lint fix

    jasalisbury committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    d867a5f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    88004d3 View commit details
    Browse the repository at this point in the history
  4. Goal takes up whole width of parent

    Small goals were not taking up the proper space. Now they always take
    100% of the parent and the trash can icon is placed to the right
    jasalisbury committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    2810613 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Refactor objectives

    Objectives no longer uses react-hook-from field arrays. This change
    simplifies the code a bit. Also avoids the fight between the multiselect
    and field arrays.
    jasalisbury committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    3a2618b View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Move goal validator to it's own file

    Splitting out the goal validator makes testing the validator easier.
    Also makes understanding the validator easier as well.
    jasalisbury committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    5f9b6bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    adccdd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Configuration menu
    Copy the full SHA
    a1156d5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0fdd46d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81e7131 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    80a54af View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    197eebb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9f88fed View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Fix tests

    jasalisbury committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    9c636cc View commit details
    Browse the repository at this point in the history
  2. Remove extra space

    jasalisbury committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    51f3567 View commit details
    Browse the repository at this point in the history
  3. Try uping jest timeout

    jasalisbury committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    b18d589 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e47fd02 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' into js-229-add-update-remove-objectives

    Conflicts:
    	frontend/yarn.lock
    jasalisbury committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4e7c4b0 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2021

  1. Configuration menu
    Copy the full SHA
    63500e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    528dc11 View commit details
    Browse the repository at this point in the history
  3. Add cancel button, remove delete "x" button

    Goals can have 0 objectives. Cancel button added to objectvies that
    will:
     * Remove the objective if it is empty
     * Cancel any updates if the objective already has values
    jasalisbury committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    336d491 View commit details
    Browse the repository at this point in the history
  4. Lint fixes

    jasalisbury committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    c43752e View commit details
    Browse the repository at this point in the history
  5. Lint fixes

    jasalisbury committed Mar 3, 2021
    Configuration menu
    Copy the full SHA
    2e3c426 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2021

  1. Merge branch 'main' into js-229-add-update-remove-objectives

    Conflicts:
    	frontend/src/pages/ActivityReport/Pages/goalsObjectives.js
    jasalisbury committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    60c053e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a07b813 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22f5fcc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ac972d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Configuration menu
    Copy the full SHA
    5117f90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    461b0b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a08fa3 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. Merge pull request #180 from adhocteam/js-229-add-update-remove-objec…

    …tives
    
    Add update remove objectives
    jasalisbury authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    cf78ad4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    263f242 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #214 from adhocteam/kw-include-context-menu

    Include the context menu in the activity reports table
    kryswisnaskas authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    e7db658 View commit details
    Browse the repository at this point in the history