-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update remove objectives #352
Commits on Feb 16, 2021
-
The frontend can add objects to goals. Uses react-hook-form's field array for objectives. I could not find an example where a field array was nested without the first array also being a part of the field array. Since goals are done with the multiselect I couldn't figure out a way to use a field array with goals. I had some issues getting everything to work but once I moved the objective's "edit" state outside of hook form and into the objective component as state things started to simplify a bit. Waiting for the recent form validation PR to merge before moving this forward. Still need to handle error messages and finalize validations.
Configuration menu - View commit details
-
Copy full SHA for 0b6728b - Browse repository at this point
Copy the full SHA 0b6728bView commit details
Commits on Feb 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8ec03c7 - Browse repository at this point
Copy the full SHA 8ec03c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 472dd7d - Browse repository at this point
Copy the full SHA 472dd7dView commit details
Commits on Feb 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c3b25d3 - Browse repository at this point
Copy the full SHA c3b25d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a2dfe7 - Browse repository at this point
Copy the full SHA 6a2dfe7View commit details
Commits on Feb 22, 2021
-
Merge branch 'main' into js-229-add-update-remove-objectives
Conflicts: frontend/src/components/MultiSelect.js
Configuration menu - View commit details
-
Copy full SHA for 6655bdc - Browse repository at this point
Copy the full SHA 6655bdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 61f2bc7 - Browse repository at this point
Copy the full SHA 61f2bc7View commit details
Commits on Feb 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 049e8e7 - Browse repository at this point
Copy the full SHA 049e8e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f02766 - Browse repository at this point
Copy the full SHA 1f02766View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac250d8 - Browse repository at this point
Copy the full SHA ac250d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09d60e8 - Browse repository at this point
Copy the full SHA 09d60e8View commit details
Commits on Feb 24, 2021
-
Single objective added to every goal if needed
If a goal has zero objectives one is added. If a goal only has one objective that objective cannot be removed.
Configuration menu - View commit details
-
Copy full SHA for 72e1d7a - Browse repository at this point
Copy the full SHA 72e1d7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d867a5f - Browse repository at this point
Copy the full SHA d867a5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 88004d3 - Browse repository at this point
Copy the full SHA 88004d3View commit details -
Goal takes up whole width of parent
Small goals were not taking up the proper space. Now they always take 100% of the parent and the trash can icon is placed to the right
Configuration menu - View commit details
-
Copy full SHA for 2810613 - Browse repository at this point
Copy the full SHA 2810613View commit details
Commits on Feb 25, 2021
-
Objectives no longer uses react-hook-from field arrays. This change simplifies the code a bit. Also avoids the fight between the multiselect and field arrays.
Configuration menu - View commit details
-
Copy full SHA for 3a2618b - Browse repository at this point
Copy the full SHA 3a2618bView commit details
Commits on Feb 26, 2021
-
Move goal validator to it's own file
Splitting out the goal validator makes testing the validator easier. Also makes understanding the validator easier as well.
Configuration menu - View commit details
-
Copy full SHA for 5f9b6bb - Browse repository at this point
Copy the full SHA 5f9b6bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for adccdd7 - Browse repository at this point
Copy the full SHA adccdd7View commit details
Commits on Mar 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a1156d5 - Browse repository at this point
Copy the full SHA a1156d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fdd46d - Browse repository at this point
Copy the full SHA 0fdd46dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 81e7131 - Browse repository at this point
Copy the full SHA 81e7131View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a54af - Browse repository at this point
Copy the full SHA 80a54afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 197eebb - Browse repository at this point
Copy the full SHA 197eebbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f88fed - Browse repository at this point
Copy the full SHA 9f88fedView commit details
Commits on Mar 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9c636cc - Browse repository at this point
Copy the full SHA 9c636ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f3567 - Browse repository at this point
Copy the full SHA 51f3567View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18d589 - Browse repository at this point
Copy the full SHA b18d589View commit details -
Configuration menu - View commit details
-
Copy full SHA for e47fd02 - Browse repository at this point
Copy the full SHA e47fd02View commit details -
Merge branch 'main' into js-229-add-update-remove-objectives
Conflicts: frontend/yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 4e7c4b0 - Browse repository at this point
Copy the full SHA 4e7c4b0View commit details
Commits on Mar 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 63500e3 - Browse repository at this point
Copy the full SHA 63500e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 528dc11 - Browse repository at this point
Copy the full SHA 528dc11View commit details -
Add cancel button, remove delete "x" button
Goals can have 0 objectives. Cancel button added to objectvies that will: * Remove the objective if it is empty * Cancel any updates if the objective already has values
Configuration menu - View commit details
-
Copy full SHA for 336d491 - Browse repository at this point
Copy the full SHA 336d491View commit details -
Configuration menu - View commit details
-
Copy full SHA for c43752e - Browse repository at this point
Copy the full SHA c43752eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e3c426 - Browse repository at this point
Copy the full SHA 2e3c426View commit details
Commits on Mar 4, 2021
-
Merge branch 'main' into js-229-add-update-remove-objectives
Conflicts: frontend/src/pages/ActivityReport/Pages/goalsObjectives.js
Configuration menu - View commit details
-
Copy full SHA for 60c053e - Browse repository at this point
Copy the full SHA 60c053eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a07b813 - Browse repository at this point
Copy the full SHA a07b813View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22f5fcc - Browse repository at this point
Copy the full SHA 22f5fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac972d9 - Browse repository at this point
Copy the full SHA ac972d9View commit details
Commits on Mar 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5117f90 - Browse repository at this point
Copy the full SHA 5117f90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 461b0b3 - Browse repository at this point
Copy the full SHA 461b0b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a08fa3 - Browse repository at this point
Copy the full SHA 5a08fa3View commit details
Commits on Mar 8, 2021
-
Merge pull request #180 from adhocteam/js-229-add-update-remove-objec…
…tives Add update remove objectives
Configuration menu - View commit details
-
Copy full SHA for cf78ad4 - Browse repository at this point
Copy the full SHA cf78ad4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 263f242 - Browse repository at this point
Copy the full SHA 263f242View commit details -
Merge pull request #214 from adhocteam/kw-include-context-menu
Include the context menu in the activity reports table
Configuration menu - View commit details
-
Copy full SHA for e7db658 - Browse repository at this point
Copy the full SHA e7db658View commit details