Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of goals in frontend #320

Merged
merged 13 commits into from
Feb 23, 2021
Merged

Creation of goals in frontend #320

merged 13 commits into from
Feb 23, 2021

Conversation

jasalisbury
Copy link
Contributor

@jasalisbury jasalisbury commented Feb 23, 2021 •
edited by rahearn
Loading

Description of change
New goals can be added to the activity report. When added the goal shows up in both the list of select-able goals and the display below goal selection.

How to test

  1. Pull down
  2. Go to reports page, select grantee and the first few grants
  3. Navigate to the objectives page
  4. Add existing and new goals to the report.

Note
Goal selections are still not being presisted, to be handled in #287

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

@jasalisbury
Can add a new goal
fb54328 
New goals can be added to the activity report. When added the goal shows
up in both the list of selectable goals and the display below goal
selection.
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
332c8da
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
62e0b6c
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
adfbe93
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
d4976cf 
Conflicts:
	frontend/src/pages/ActivityReport/Pages/components/GoalPicker.js
@jasalisbury
Goal picker test uses formProvider
b3d4070
@jasalisbury
Forgot to save this file, removal of props sent to goalpicker
19eeee6
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
a7b560d
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
c3212f0
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
2828f20
@jasalisbury
Merge branch 'main' into js-101-create-new-goal
9a88efd
@jasalisbury
Remove fake goals and eslint disable that is not needed
0e2a800
@jasalisbury
Merge pull request #179 from adhocteam/js-101-create-new-goal
4b1f4e8 
Can add a new goal
@jasalisbury jasalisbury requested a review from rahearn February 23, 2021 15:32
@rahearn rahearn merged commit 208297b into HHS:main Feb 23, 2021
PatricePascual-ACF pushed a commit that referenced this pull request Jun 9, 2021
@dcloud
Merge pull request #320 from adhocteam/TTAHUB-147/filtering-menu-styl…
e90b2e3 
…e-updates

[TTAHUB-147]: Update styles for menus on AR tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahearn rahearn rahearn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new goal in an Activity Report
2 participants
@jasalisbury @rahearn