Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit a report for approval #264

Merged
merged 13 commits into from
Jan 22, 2021
Merged

Submit a report for approval #264

merged 13 commits into from
Jan 22, 2021

Conversation

jasalisbury
Copy link
Contributor

@jasalisbury jasalisbury commented Jan 22, 2021

Description of change

A report can now be submitted for approval. Every page must be "completed" before a report can be submitted. A single manager must be assigned as the approving manager.

How to test

  1. Pull down and run migrations
  2. Fill out a complete report
  3. Submit the report, note the review page in navigation is marked "submitted"

Or test it out on dev. If you don't see any approving managers available to select make sure your user has READ_WRITE_REPORTS permissions on region 1.

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

jasalisbury and others added 13 commits January 20, 2021 11:28
ApprovingManagerId was previously being set to "" which postgres didn't
like (since "" is not an integer). Can't simply set "valueAsNumber"
because null values become 0. Explicitly set "0" to null
This solves a few problems. Reports are now properly reset when clicking
"new" after submitting a report. Now components can receive the activity
report id if needed (for example file upload).
Conflicts:
	.circleci/config.yml
Serialize test runs to workaround validation issues
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good, though I did create two stories to improve things soon:

#265 which I wish I had noticed during the initial draft submission story.
#266 that we can't quite work on yet anyway.

@rahearn rahearn merged commit 4948bd3 into HHS:main Jan 22, 2021
@jasalisbury
Copy link
Contributor Author

This all looks good, though I did create two stories to improve things soon:

#265 which I wish I had noticed during the initial draft submission story.

I already started in on #265 before I saw this comment, should come across in this PR, adhocteam#127

rahearn added a commit that referenced this pull request Mar 30, 2021
Remove early exit from reconcile CLI script
rahearn pushed a commit that referenced this pull request Apr 15, 2021
commit 8d514e2
Merge: 2d20135 f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 16:45:17 2021 -0400

    Merge pull request #264 from adhocteam/reconcile-script-exit

    Remove early exit from reconcile CLI script

commit f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 15:49:51 2021 -0400

    Remove early exit from reconcile CLI script

commit 0b2e663
Merge: c5acb18 2d20135
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 13:12:55 2021 -0400

    Merge pull request #412 from adhocteam/main

    Upload scan file size to 30MB

commit 2d20135
Merge: b5298a2 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 12:54:49 2021 -0400

    Merge pull request #263 from HHS/clamav-file-size-fix

    Increase max file size for scanned files

commit 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 11:47:35 2021 -0400

    Increase max file size for scanning files to 30MB.

    Largest file uploaded in Smartsheet was 25.2MB

commit c5acb18
Merge: 6a735e3 b5298a2
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 10:13:34 2021 -0400

    Merge pull request #411 from adhocteam/main

    Smartsheet reconciliation & attachments

commit b5298a2
Merge: 87cac4a 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:57:13 2021 -0400

    Merge pull request #262 from adhocteam/cfignore-legacy-scripts

    Prevent legacy scripts from deploying

commit 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:39:56 2021 -0400

    Deploy to sandbox to verify cfignore behavior

commit db7dfee
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:37:47 2021 -0400

    Don't deploy smartsheet_scripts

commit 87cac4a
Merge: af74b8e 7612222
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:21:06 2021 -0400

    Merge pull request #257 from adhocteam/legacy-comment-file-upload

    Legacy report comments and file upload

commit 7612222
Merge: a69be99 af74b8e
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:13:05 2021 -0400

    Merge branch 'adhoc-main' into legacy-comment-file-upload

    * adhoc-main:
      fix apiDirectory.test.js
      update activityReports.test.js
      update activityReports.test.js
      update usernames to be unique
      update legacyreport.test.js
      update legacyreport.test.js
      more debugging
      more tmp debug
      temp debug
      Update legacyreport.test.js
      remove temp debugging
      add temp debugging
      revert UserInfo.js
      update frontend UserInfo.js
      update users.test.js
      fix frontend UserInfo.js test
      add missing hsesUserId
      add unique hsesUsername to tests

commit af74b8e
Merge: cd700ad b3223a8
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:04:41 2021 -0400

    Merge pull request #260 from adhocteam/cm-fix-ci-backend-tests

    Cm fix ci backend tests

commit b3223a8
Author: Chuck McAndrew <[email protected]>
Date:   Thu Mar 25 17:04:48 2021 -0400

    fix apiDirectory.test.js

commit 21db847
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 21:02:12 2021 -0400

    update activityReports.test.js

commit 01e3c05
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:56:47 2021 -0400

    update activityReports.test.js

commit 3f16fa1
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:53:26 2021 -0400

    update usernames to be unique

commit 83490c0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 15:56:17 2021 -0400

    update legacyreport.test.js

commit 2664ef0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:32:53 2021 -0400

    update legacyreport.test.js

commit 3e98748
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:26:18 2021 -0400

    more debugging

commit 2d1bac6
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:19:30 2021 -0400

    more tmp debug

commit f917992
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:13:45 2021 -0400

    temp debug

commit 33fe0c5
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:04:09 2021 -0400

    Update legacyreport.test.js

commit 282362e
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:58:31 2021 -0400

    remove temp debugging

commit d6084e8
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:45:34 2021 -0400

    add temp debugging

commit 15f4180
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:41:53 2021 -0400

    revert UserInfo.js

commit 2158d8f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:33:23 2021 -0400

    update frontend UserInfo.js

commit 2b54448
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:29:01 2021 -0400

    update users.test.js

commit 4561c9f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:20:01 2021 -0400

    fix frontend UserInfo.js test

commit 3bdb4e0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:18:03 2021 -0400

    add missing hsesUserId

commit 5da4fe7
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:03:59 2021 -0400

    add unique hsesUsername to tests

commit a69be99
Merge: aeec8a0 cd700ad
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:33:10 2021 -0400

    Merge branch 'main' into legacy-comment-file-upload

commit aeec8a0
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:22:20 2021 -0400

    coerceReportId now works with either string or number regions

commit ce3be5f
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:11:28 2021 -0400

    Linter fixes

commit 1b31acf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 09:59:04 2021 -0400

    Include attchment transition script in full repo

commit 6a735e3
Merge: 982e021 9497312
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:24:49 2021 -0400

    Merge pull request #408 from adhocteam/main

    IE keyboard navigation fix

commit dfc5633
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:03:34 2021 -0400

    Ensure legacy AR ids have a 2 digit region number

commit 44b789e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 12:00:29 2021 -0400

    Linter fixes

commit f867c8e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 11:53:20 2021 -0400

    Add general SCANNING_FAILED status to capture other failure reasons

    Such as: "[ERR_FR_MAX_BODY_LENGTH_EXCEEDED]: Request body larger than maxBodyLength"

commit 803ba2b
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 10:48:24 2021 -0400

    Display comments and attachments in legacy reports

commit 4856195
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 16:19:36 2021 -0400

    Allow admins to upload files on any report

commit be00f49
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 14:44:31 2021 -0400

    Allow legacy AR comments to be updated

commit 982e021
Merge: 13fff8b 6c28851
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 13:21:10 2021 -0400

    Merge pull request #405 from adhocteam/main

    External Dialog Link

commit 13fff8b
Merge: 8caa9af f7074ce
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 08:47:37 2021 -0400

    Merge pull request #403 from adhocteam/main

    Edit next steps in-place; Fix warnings in tests

commit 8caa9af
Merge: 99ab32e 576adbf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 13:15:51 2021 -0400

    Merge pull request #402 from adhocteam/main

    Fix layout stacking in print styles

commit 99ab32e
Merge: 3777c68 dd9b1aa
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 11:22:30 2021 -0400

    Merge pull request #400 from adhocteam/main

    Small frontend fixes

commit 3777c68
Merge: 8d085d0 23f4978
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 10:05:29 2021 -0400

    Merge pull request #399 from adhocteam/main

    Fix read region access issue on first login

commit 8d085d0
Merge: 57e3152 81e876f
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 16 15:26:01 2021 -0400

    Merge pull request #395 from adhocteam/main

    Rolling deploys
rahearn pushed a commit that referenced this pull request Apr 15, 2021
commit 0b5ea01
Merge: 53922f8 d9ac78c
Author: Daniel Gopar <[email protected]>
Date:   Tue Mar 30 15:07:24 2021 -0700

    Merge pull request #266 from adhocteam/TTAHUB-57-screen-reader-update

    Screen reader update

commit d9ac78c
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 14:34:19 2021 -0700

    TTAHUB-57 Fix wording for grantee prompt

commit 3660e10
Merge: 48bda03 53922f8
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 30 17:01:27 2021 -0400

    Merge branch 'main' into TTAHUB-57-screen-reader-update

commit 53922f8
Merge: 8d514e2 8b99f94
Author: Chuck McAndrew <[email protected]>
Date:   Tue Mar 30 11:36:48 2021 -0400

    Merge pull request #258 from adhocteam/cm-60-add-nightly-reconcilliation

    Cm 60 add nightly reconcilliation

commit 48bda03
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 08:26:46 2021 -0700

    TTAHUB-57 Fix wording

commit 52000b0
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 05:56:40 2021 -0700

    TTAHUB-57 Add more screen reader info

commit 8b99f94
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 17:01:03 2021 -0400

    reenable new relic and remove catch block from src/worker.js

commit 274c644
Merge: 30b7c6a 8d514e2
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 16:49:29 2021 -0400

    Merge branch 'adhoc-main' into cm-60-add-nightly-reconcilliation

    * adhoc-main:
      Remove early exit from reconcile CLI script

commit 8d514e2
Merge: 2d20135 f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 16:45:17 2021 -0400

    Merge pull request #264 from adhocteam/reconcile-script-exit

    Remove early exit from reconcile CLI script

commit 30b7c6a
Merge: 857b86d 2d20135
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 16:29:46 2021 -0400

    Merge branch 'main' into cm-60-add-nightly-reconcilliation

commit f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 15:49:51 2021 -0400

    Remove early exit from reconcile CLI script

commit 0b2e663
Merge: c5acb18 2d20135
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 13:12:55 2021 -0400

    Merge pull request #412 from adhocteam/main

    Upload scan file size to 30MB

commit 2d20135
Merge: b5298a2 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 12:54:49 2021 -0400

    Merge pull request #263 from HHS/clamav-file-size-fix

    Increase max file size for scanned files

commit 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 11:47:35 2021 -0400

    Increase max file size for scanning files to 30MB.

    Largest file uploaded in Smartsheet was 25.2MB

commit c5acb18
Merge: 6a735e3 b5298a2
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 10:13:34 2021 -0400

    Merge pull request #411 from adhocteam/main

    Smartsheet reconciliation & attachments

commit b5298a2
Merge: 87cac4a 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:57:13 2021 -0400

    Merge pull request #262 from adhocteam/cfignore-legacy-scripts

    Prevent legacy scripts from deploying

commit 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:39:56 2021 -0400

    Deploy to sandbox to verify cfignore behavior

commit db7dfee
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:37:47 2021 -0400

    Don't deploy smartsheet_scripts

commit 87cac4a
Merge: af74b8e 7612222
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:21:06 2021 -0400

    Merge pull request #257 from adhocteam/legacy-comment-file-upload

    Legacy report comments and file upload

commit 7612222
Merge: a69be99 af74b8e
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:13:05 2021 -0400

    Merge branch 'adhoc-main' into legacy-comment-file-upload

    * adhoc-main:
      fix apiDirectory.test.js
      update activityReports.test.js
      update activityReports.test.js
      update usernames to be unique
      update legacyreport.test.js
      update legacyreport.test.js
      more debugging
      more tmp debug
      temp debug
      Update legacyreport.test.js
      remove temp debugging
      add temp debugging
      revert UserInfo.js
      update frontend UserInfo.js
      update users.test.js
      fix frontend UserInfo.js test
      add missing hsesUserId
      add unique hsesUsername to tests

commit 857b86d
Merge: 8989d9e af74b8e
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 09:06:11 2021 -0400

    Merge branch 'main' into cm-60-add-nightly-reconcilliation

commit af74b8e
Merge: cd700ad b3223a8
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:04:41 2021 -0400

    Merge pull request #260 from adhocteam/cm-fix-ci-backend-tests

    Cm fix ci backend tests

commit b3223a8
Author: Chuck McAndrew <[email protected]>
Date:   Thu Mar 25 17:04:48 2021 -0400

    fix apiDirectory.test.js

commit 21db847
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 21:02:12 2021 -0400

    update activityReports.test.js

commit 01e3c05
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:56:47 2021 -0400

    update activityReports.test.js

commit 3f16fa1
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:53:26 2021 -0400

    update usernames to be unique

commit 83490c0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 15:56:17 2021 -0400

    update legacyreport.test.js

commit 2664ef0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:32:53 2021 -0400

    update legacyreport.test.js

commit 3e98748
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:26:18 2021 -0400

    more debugging

commit 2d1bac6
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:19:30 2021 -0400

    more tmp debug

commit f917992
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:13:45 2021 -0400

    temp debug

commit 33fe0c5
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:04:09 2021 -0400

    Update legacyreport.test.js

commit 282362e
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:58:31 2021 -0400

    remove temp debugging

commit d6084e8
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:45:34 2021 -0400

    add temp debugging

commit 15f4180
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:41:53 2021 -0400

    revert UserInfo.js

commit 2158d8f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:33:23 2021 -0400

    update frontend UserInfo.js

commit 2b54448
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:29:01 2021 -0400

    update users.test.js

commit 4561c9f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:20:01 2021 -0400

    fix frontend UserInfo.js test

commit 3bdb4e0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:18:03 2021 -0400

    add missing hsesUserId

commit 5da4fe7
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:03:59 2021 -0400

    add unique hsesUsername to tests

commit a69be99
Merge: aeec8a0 cd700ad
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:33:10 2021 -0400

    Merge branch 'main' into legacy-comment-file-upload

commit 8989d9e
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 11:33:05 2021 -0400

    Squashed commit of the following:

    commit cd700ad
    Merge: 9497312 af81eaa
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:32:17 2021 -0400

        Merge pull request #255 from adhocteam/cm-60-reconcile-legacy-reports

        Cm 60 reconcile legacy reports

    commit af81eaa
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:19:00 2021 -0400

        remove babel-node from reconcile:legacy

    commit d2b329a
    Merge: 2951bc8 2e994a9
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:06:52 2021 -0400

        Merge branch 'cm-60-reconcile-legacy-reports' of github.com:adhocteam/Head-Start-TTADP into cm-60-reconcile-legacy-reports

    commit 2951bc8
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:06:50 2021 -0400

        add catch to tools/reconcileLegacyReports.js and reconcile:legacy:local command to package.json

    commit 2e994a9
    Merge: d8f1d2e 9497312
    Author: Chuck McAndrew <[email protected]>
    Date:   Tue Mar 23 17:32:11 2021 -0400

        Merge branch 'main' into cm-60-reconcile-legacy-reports

    commit 9497312
    Merge: 6c28851 80c4049
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 16:03:16 2021 -0400

        Merge pull request #256 from adhocteam/kw-ie-keyboard-nav

        IE keyboard navigation fix

    commit 80c4049
    Merge: e2bf1fe 6c28851
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 14:45:41 2021 -0400

        Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-ie-keyboard-nav

    commit e2bf1fe
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 09:58:49 2021 -0400

        Deploy to sandbox

    commit 8c42486
    Author: kryswisnaskas <[email protected]>
    Date:   Mon Mar 22 11:47:15 2021 -0400

        Redirect focus after date pick

commit aeec8a0
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:22:20 2021 -0400

    coerceReportId now works with either string or number regions

commit ce3be5f
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:11:28 2021 -0400

    Linter fixes

commit 1b31acf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 09:59:04 2021 -0400

    Include attchment transition script in full repo

commit 26e2b08
Author: Chuck McAndrew <[email protected]>
Date:   Tue Mar 23 17:31:13 2021 -0400

    Add recurring event to reconcile legacy reports

commit 6a735e3
Merge: 982e021 9497312
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:24:49 2021 -0400

    Merge pull request #408 from adhocteam/main

    IE keyboard navigation fix

commit dfc5633
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:03:34 2021 -0400

    Ensure legacy AR ids have a 2 digit region number

commit 44b789e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 12:00:29 2021 -0400

    Linter fixes

commit f867c8e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 11:53:20 2021 -0400

    Add general SCANNING_FAILED status to capture other failure reasons

    Such as: "[ERR_FR_MAX_BODY_LENGTH_EXCEEDED]: Request body larger than maxBodyLength"

commit 803ba2b
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 10:48:24 2021 -0400

    Display comments and attachments in legacy reports

commit 4856195
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 16:19:36 2021 -0400

    Allow admins to upload files on any report

commit be00f49
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 14:44:31 2021 -0400

    Allow legacy AR comments to be updated

commit 982e021
Merge: 13fff8b 6c28851
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 13:21:10 2021 -0400

    Merge pull request #405 from adhocteam/main

    External Dialog Link

commit 13fff8b
Merge: 8caa9af f7074ce
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 08:47:37 2021 -0400

    Merge pull request #403 from adhocteam/main

    Edit next steps in-place; Fix warnings in tests

commit 8caa9af
Merge: 99ab32e 576adbf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 13:15:51 2021 -0400

    Merge pull request #402 from adhocteam/main

    Fix layout stacking in print styles

commit 99ab32e
Merge: 3777c68 dd9b1aa
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 11:22:30 2021 -0400

    Merge pull request #400 from adhocteam/main

    Small frontend fixes

commit 3777c68
Merge: 8d085d0 23f4978
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 10:05:29 2021 -0400

    Merge pull request #399 from adhocteam/main

    Fix read region access issue on first login

commit 8d085d0
Merge: 57e3152 81e876f
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 16 15:26:01 2021 -0400

    Merge pull request #395 from adhocteam/main

    Rolling deploys
rahearn pushed a commit that referenced this pull request Apr 15, 2021
commit 251eb04
Merge: d824f6e 1e17732
Author: kryswisnaskas <[email protected]>
Date:   Fri Apr 2 14:47:19 2021 -0400

    Merge pull request #268 from adhocteam/kw-fix-blank-screen

    Prevent blank screen

commit 1e17732
Author: kryswisnaskas <[email protected]>
Date:   Fri Apr 2 13:44:30 2021 -0400

    Prevent blank screen

commit d824f6e
Merge: 0b5ea01 5e11452
Author: Daniel Cloud <[email protected]>
Date:   Wed Mar 31 12:26:28 2021 -0400

    Merge pull request #259 from adhocteam/dcloud/TTAHUB-35-download-ar-as-csv

    [TTAHUB 35]: Download Activity Reports as csv files

commit 5e11452
Merge: 58d4241 0b5ea01
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 31 10:36:37 2021 -0400

    Merge branch 'main' into dcloud/TTAHUB-35-download-ar-as-csv

commit 0b5ea01
Merge: 53922f8 d9ac78c
Author: Daniel Gopar <[email protected]>
Date:   Tue Mar 30 15:07:24 2021 -0700

    Merge pull request #266 from adhocteam/TTAHUB-57-screen-reader-update

    Screen reader update

commit d9ac78c
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 14:34:19 2021 -0700

    TTAHUB-57 Fix wording for grantee prompt

commit 3660e10
Merge: 48bda03 53922f8
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 30 17:01:27 2021 -0400

    Merge branch 'main' into TTAHUB-57-screen-reader-update

commit 58d4241
Merge: 63a9299 53922f8
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 30 11:37:22 2021 -0400

    Merge branch 'main' into dcloud/TTAHUB-35-download-ar-as-csv

commit 53922f8
Merge: 8d514e2 8b99f94
Author: Chuck McAndrew <[email protected]>
Date:   Tue Mar 30 11:36:48 2021 -0400

    Merge pull request #258 from adhocteam/cm-60-add-nightly-reconcilliation

    Cm 60 add nightly reconcilliation

commit 48bda03
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 08:26:46 2021 -0700

    TTAHUB-57 Fix wording

commit 52000b0
Author: Daniel Riquiac Gopar <[email protected]>
Date:   Tue Mar 30 05:56:40 2021 -0700

    TTAHUB-57 Add more screen reader info

commit 8b99f94
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 17:01:03 2021 -0400

    reenable new relic and remove catch block from src/worker.js

commit 274c644
Merge: 30b7c6a 8d514e2
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 16:49:29 2021 -0400

    Merge branch 'adhoc-main' into cm-60-add-nightly-reconcilliation

    * adhoc-main:
      Remove early exit from reconcile CLI script

commit 8d514e2
Merge: 2d20135 f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 16:45:17 2021 -0400

    Merge pull request #264 from adhocteam/reconcile-script-exit

    Remove early exit from reconcile CLI script

commit 30b7c6a
Merge: 857b86d 2d20135
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 16:29:46 2021 -0400

    Merge branch 'main' into cm-60-add-nightly-reconcilliation

commit f0dba5c
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 15:49:51 2021 -0400

    Remove early exit from reconcile CLI script

commit 0b2e663
Merge: c5acb18 2d20135
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 13:12:55 2021 -0400

    Merge pull request #412 from adhocteam/main

    Upload scan file size to 30MB

commit 63a9299
Merge: 3a6e7c4 2d20135
Author: Daniel Cloud <[email protected]>
Date:   Fri Mar 26 12:55:29 2021 -0400

    Merge branch 'main' into dcloud/TTAHUB-35-download-ar-as-csv

commit 2d20135
Merge: b5298a2 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 12:54:49 2021 -0400

    Merge pull request #263 from HHS/clamav-file-size-fix

    Increase max file size for scanned files

commit 3a48108
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 11:47:35 2021 -0400

    Increase max file size for scanning files to 30MB.

    Largest file uploaded in Smartsheet was 25.2MB

commit 3a6e7c4
Merge: d54affc b5298a2
Author: Daniel Cloud <[email protected]>
Date:   Fri Mar 26 11:43:12 2021 -0400

    Merge branch 'main' into dcloud/TTAHUB-35-download-ar-as-csv

commit d54affc
Author: Daniel Cloud <[email protected]>
Date:   Fri Mar 26 10:55:46 2021 -0400

    [TTAHUB-35]: Add a bit of API documentation for download endpoint

commit c5acb18
Merge: 6a735e3 b5298a2
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 10:13:34 2021 -0400

    Merge pull request #411 from adhocteam/main

    Smartsheet reconciliation & attachments

commit b5298a2
Merge: 87cac4a 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:57:13 2021 -0400

    Merge pull request #262 from adhocteam/cfignore-legacy-scripts

    Prevent legacy scripts from deploying

commit 2baf59f
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:39:56 2021 -0400

    Deploy to sandbox to verify cfignore behavior

commit db7dfee
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:37:47 2021 -0400

    Don't deploy smartsheet_scripts

commit 87cac4a
Merge: af74b8e 7612222
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:21:06 2021 -0400

    Merge pull request #257 from adhocteam/legacy-comment-file-upload

    Legacy report comments and file upload

commit 7612222
Merge: a69be99 af74b8e
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:13:05 2021 -0400

    Merge branch 'adhoc-main' into legacy-comment-file-upload

    * adhoc-main:
      fix apiDirectory.test.js
      update activityReports.test.js
      update activityReports.test.js
      update usernames to be unique
      update legacyreport.test.js
      update legacyreport.test.js
      more debugging
      more tmp debug
      temp debug
      Update legacyreport.test.js
      remove temp debugging
      add temp debugging
      revert UserInfo.js
      update frontend UserInfo.js
      update users.test.js
      fix frontend UserInfo.js test
      add missing hsesUserId
      add unique hsesUsername to tests

commit 857b86d
Merge: 8989d9e af74b8e
Author: Chuck McAndrew <[email protected]>
Date:   Fri Mar 26 09:06:11 2021 -0400

    Merge branch 'main' into cm-60-add-nightly-reconcilliation

commit af74b8e
Merge: cd700ad b3223a8
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 26 09:04:41 2021 -0400

    Merge pull request #260 from adhocteam/cm-fix-ci-backend-tests

    Cm fix ci backend tests

commit 111a2fe
Author: Daniel Cloud <[email protected]>
Date:   Thu Mar 25 17:49:34 2021 -0400

    [TTAHUB-35]: reportIds come in as numeric strings, so test against
    refexp

commit 38438e8
Author: Daniel Cloud <[email protected]>
Date:   Thu Mar 25 17:29:37 2021 -0400

    [TTAHUB-35]: improve handling of input ids in getDownloadableActivityReports

commit bfbf266
Author: Daniel Cloud <[email protected]>
Date:   Thu Mar 25 17:10:42 2021 -0400

    [TTAHUB-35]: Add tests for downloadReports handler.

commit b3223a8
Author: Chuck McAndrew <[email protected]>
Date:   Thu Mar 25 17:04:48 2021 -0400

    fix apiDirectory.test.js

commit 2601922
Author: Daniel Cloud <[email protected]>
Date:   Thu Mar 25 15:30:16 2021 -0400

    [TTAHUB-35]: Add tests for getDownloadableActivityReports service.

commit 81e2050
Author: Daniel Cloud <[email protected]>
Date:   Thu Mar 25 10:46:06 2021 -0400

    [TTAHUB-35]: Remove manual ordering, order by report id.

commit 21db847
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 21:02:12 2021 -0400

    update activityReports.test.js

commit 01e3c05
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:56:47 2021 -0400

    update activityReports.test.js

commit 3f16fa1
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 20:53:26 2021 -0400

    update usernames to be unique

commit 222fa88
Author: Daniel Cloud <[email protected]>
Date:   Wed Mar 24 18:44:22 2021 -0400

    [TTAHUB-35]: download endpoint accepts `report` query params to select
    which reports to download.

commit 15eb354
Author: Daniel Cloud <[email protected]>
Date:   Wed Mar 24 16:01:12 2021 -0400

    [TTAHUB-35]: Update service function to check for id in reportIds.
    Remove ordering

commit 83490c0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 15:56:17 2021 -0400

    update legacyreport.test.js

commit eefc18a
Author: Daniel Cloud <[email protected]>
Date:   Wed Mar 24 15:05:55 2021 -0400

    [TTAHUB-35]: Increase tests for csv transformer.

commit 2664ef0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:32:53 2021 -0400

    update legacyreport.test.js

commit 3e98748
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:26:18 2021 -0400

    more debugging

commit 2d1bac6
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:19:30 2021 -0400

    more tmp debug

commit f917992
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:13:45 2021 -0400

    temp debug

commit 33fe0c5
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 14:04:09 2021 -0400

    Update legacyreport.test.js

commit 282362e
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:58:31 2021 -0400

    remove temp debugging

commit d6084e8
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:45:34 2021 -0400

    add temp debugging

commit 15f4180
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:41:53 2021 -0400

    revert UserInfo.js

commit 2158d8f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:33:23 2021 -0400

    update frontend UserInfo.js

commit 2b54448
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:29:01 2021 -0400

    update users.test.js

commit 4561c9f
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:20:01 2021 -0400

    fix frontend UserInfo.js test

commit 3bdb4e0
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:18:03 2021 -0400

    add missing hsesUserId

commit 5da4fe7
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 13:03:59 2021 -0400

    add unique hsesUsername to tests

commit a69be99
Merge: aeec8a0 cd700ad
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:33:10 2021 -0400

    Merge branch 'main' into legacy-comment-file-upload

commit 8989d9e
Author: Chuck McAndrew <[email protected]>
Date:   Wed Mar 24 11:33:05 2021 -0400

    Squashed commit of the following:

    commit cd700ad
    Merge: 9497312 af81eaa
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:32:17 2021 -0400

        Merge pull request #255 from adhocteam/cm-60-reconcile-legacy-reports

        Cm 60 reconcile legacy reports

    commit af81eaa
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:19:00 2021 -0400

        remove babel-node from reconcile:legacy

    commit d2b329a
    Merge: 2951bc8 2e994a9
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:06:52 2021 -0400

        Merge branch 'cm-60-reconcile-legacy-reports' of github.com:adhocteam/Head-Start-TTADP into cm-60-reconcile-legacy-reports

    commit 2951bc8
    Author: Chuck McAndrew <[email protected]>
    Date:   Wed Mar 24 11:06:50 2021 -0400

        add catch to tools/reconcileLegacyReports.js and reconcile:legacy:local command to package.json

    commit 2e994a9
    Merge: d8f1d2e 9497312
    Author: Chuck McAndrew <[email protected]>
    Date:   Tue Mar 23 17:32:11 2021 -0400

        Merge branch 'main' into cm-60-reconcile-legacy-reports

    commit 9497312
    Merge: 6c28851 80c4049
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 16:03:16 2021 -0400

        Merge pull request #256 from adhocteam/kw-ie-keyboard-nav

        IE keyboard navigation fix

    commit 80c4049
    Merge: e2bf1fe 6c28851
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 14:45:41 2021 -0400

        Merge branch 'main' of https://github.com/adhocteam/Head-Start-TTADP into kw-ie-keyboard-nav

    commit e2bf1fe
    Author: kryswisnaskas <[email protected]>
    Date:   Tue Mar 23 09:58:49 2021 -0400

        Deploy to sandbox

    commit 8c42486
    Author: kryswisnaskas <[email protected]>
    Date:   Mon Mar 22 11:47:15 2021 -0400

        Redirect focus after date pick

commit aeec8a0
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:22:20 2021 -0400

    coerceReportId now works with either string or number regions

commit ce3be5f
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 11:11:28 2021 -0400

    Linter fixes

commit 1b31acf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 24 09:59:04 2021 -0400

    Include attchment transition script in full repo

commit 9fab939
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 23 18:41:00 2021 -0400

    AR to csv: Simplify transformRelatedModel and begin tests

commit 26e2b08
Author: Chuck McAndrew <[email protected]>
Date:   Tue Mar 23 17:31:13 2021 -0400

    Add recurring event to reconcile legacy reports

commit 6a735e3
Merge: 982e021 9497312
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:24:49 2021 -0400

    Merge pull request #408 from adhocteam/main

    IE keyboard navigation fix

commit dfc5633
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 16:03:34 2021 -0400

    Ensure legacy AR ids have a 2 digit region number

commit 191dc92
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 23 15:00:22 2021 -0400

    Make sure csv download functions grab all needed fields

commit da6681a
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 23 14:40:50 2021 -0400

    Rough out downloadReports for downloadable report csvs

commit 44b789e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 12:00:29 2021 -0400

    Linter fixes

commit f867c8e
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 11:53:20 2021 -0400

    Add general SCANNING_FAILED status to capture other failure reasons

    Such as: "[ERR_FR_MAX_BODY_LENGTH_EXCEEDED]: Request body larger than maxBodyLength"

commit 803ba2b
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 23 10:48:24 2021 -0400

    Display comments and attachments in legacy reports

commit 8161178
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 23 10:37:07 2021 -0400

    Add attachments ar builder. Gracefully handle mising fields, since API endpoints determine what fields appear

commit 0003c81
Author: Daniel Cloud <[email protected]>
Date:   Tue Mar 23 09:49:20 2021 -0400

    Add generic transformer for m2m fields

commit 1c99b23
Author: Daniel Cloud <[email protected]>
Date:   Mon Mar 22 18:36:34 2021 -0400

    Get most transform- functions in place for csv transformation

commit 4856195
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 16:19:36 2021 -0400

    Allow admins to upload files on any report

commit 985fc42
Author: Daniel Cloud <[email protected]>
Date:   Mon Mar 22 14:07:15 2021 -0400

    Add initial version of src/lib/transform for transforming data to csv

commit be00f49
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 14:44:31 2021 -0400

    Allow legacy AR comments to be updated

commit 982e021
Merge: 13fff8b 6c28851
Author: Ryan Ahearn <[email protected]>
Date:   Mon Mar 22 13:21:10 2021 -0400

    Merge pull request #405 from adhocteam/main

    External Dialog Link

commit 13fff8b
Merge: 8caa9af f7074ce
Author: Ryan Ahearn <[email protected]>
Date:   Fri Mar 19 08:47:37 2021 -0400

    Merge pull request #403 from adhocteam/main

    Edit next steps in-place; Fix warnings in tests

commit 8caa9af
Merge: 99ab32e 576adbf
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 13:15:51 2021 -0400

    Merge pull request #402 from adhocteam/main

    Fix layout stacking in print styles

commit 99ab32e
Merge: 3777c68 dd9b1aa
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 11:22:30 2021 -0400

    Merge pull request #400 from adhocteam/main

    Small frontend fixes

commit 3777c68
Merge: 8d085d0 23f4978
Author: Ryan Ahearn <[email protected]>
Date:   Wed Mar 17 10:05:29 2021 -0400

    Merge pull request #399 from adhocteam/main

    Fix read region access issue on first login

commit 8d085d0
Merge: 57e3152 81e876f
Author: Ryan Ahearn <[email protected]>
Date:   Tue Mar 16 15:26:01 2021 -0400

    Merge pull request #395 from adhocteam/main

    Rolling deploys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and submit a report for approval
2 participants