[TTAHUB-3402] Hook up QA widgets to BE #2394

AdamAdHocTeam · 2024-10-01T15:16:14Z

Description of change

This hooks up the new QA dashboard to the SSDI.

How to test

Review the code
Make sure all widgets are displaying correctly
Verify filters work correctly
Sorting and exporting should work as it does on other pages

Issue(s)

Checklists

Every PR

Meets issue criteria
JIRA ticket status updated
Code is meaningfully tested
Meets accessibility standards (WCAG 2.1 Levels A, AA)
API Documentation updated
Boundary diagram updated
Logical Data Model updated
Architectural Decision Records written for major infrastructure decisions
UI review complete

Before merge to main

OHS demo complete
Ready to create production PR

Production Deploy

Staging smoke test completed

After merge/deploy

Update JIRA ticket status

…02-connect-be-overview

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

…02-connect-be-overview

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

…02-connect-be-overview

thewatermethod · 2024-10-16T20:00:24Z

Looked at this branch on dev, on the main QA dash landing page the filters don't seem to update the page

thewatermethod · 2024-10-16T20:04:46Z

The new dashboard routes 404 and I also don't see them in your code so I expect you have a bad merge w/main

AdamAdHocTeam · 2024-10-17T12:36:55Z

The new dashboard routes 404 and I also don't see them in your code so I expect you have a bad merge w/main

Bad merge should now be fixed.

thewatermethod · 2024-10-17T13:29:39Z

Verify filters work correctly

First two filters I tried on the landing page:

Report ID contains does not change the result set as far as I can tell, at least on the overview widget
Created on throws an error

thewatermethod · 2024-10-17T13:41:07Z

frontend/src/fetchers/ssdi.js

+ 'region',
+ 'regionIds',


why do we need both?

I was waiting till Garrett updated the BE, I have removed it.

thewatermethod · 2024-10-17T13:53:24Z

frontend/src/fetchers/ssdi.js

 const url = getSelfServiceUrl(filterName, filters);
-
- const response = await get(url);
+ const urlToUse = url + (dataSetSelection && dataSetSelection.length ? dataSetSelection.map((s) => `&dataSetSelection[]=${s}`).join('') : '');


do we need to account for this case (dataSetSelection is falsy?) If so, did we add a test?
Note also there is no need to check for length: if dataSetSelection is empty, the map will be an empty array and will join out to be the same as your else statement

Removed checks.

thewatermethod · 2024-10-17T13:54:12Z

frontend/src/hooks/useWidgetSorting.js

+ const requestSort = useCallback((sortBy, passedDirection = null) => {
 // Get sort direction.
 let direction = 'asc';
- if (
+ if (passedDirection) {
+ // If the direction is passed, use it.
+ direction = passedDirection;
+ } else if (


Can you leave a comment explaining why we need to optionally override the sortConfig direction?

Just seems like you could mutate the object that already has the direction in it instead of adding another parameter and all this additional logic

I added a comment.

This seems to just take the opposite of whats currently set in the sortConfig (arrow sort).

thewatermethod · 2024-10-17T13:56:18Z

frontend/src/pages/QADashboard/Components/GoalCard.js

@@ -15,7 +17,7 @@ function GoalCard({
 <DataRow
 label="Goal number"
 value={(
- <Link to="recipient-tta-records/376/region/1/goals?id[]=83697">
+ <Link to={`../../recipient-tta-records/${recipientId}/region/${regionId}/goals?id[]=${goal.id}`}>


minor but I don't think you need the ../../, just starting with "/recipient-tta-records" should do it

You are correct.

thewatermethod · 2024-10-17T13:57:19Z

frontend/src/pages/QADashboard/RecipientsWithNoTta/index.js

+ });
+ updateError('');
+ } catch (e) {
+ updateError('Unable to fetch QA data');


No test for this case I don't think

thewatermethod · 2024-10-17T14:02:01Z

frontend/src/widgets/PercentageActivityReportByRole.js

@@ -24,7 +24,7 @@ const DEFAULT_SORT_CONFIG = {
 activePage: 1,
 };

-export default function PercentageActivityReportByRole({ data }) {
+export default function PercentageActivityReportByRole({ data, loading }) {


I left the loading attribute off these graphs on purpose; we don't really want all those announcements/mini "loading" spinners since the whole page is wrapped in a loader. There's an outstanding accessibility ticket to fix it. everywhere.

Ok I removed loaders from all of the individual widgets and just added one loader on the dashboard itself.

This has been cleaned up.

thewatermethod · 2024-10-17T14:03:01Z

frontend/src/pages/QADashboard/RecipientsWithClassScoresAndGoals/index.js

+ }
+ }
+ // Call resources fetch.
+ fetchQaDat();


can we fix the spelling of this method?

thewatermethod · 2024-10-17T14:03:10Z

frontend/src/pages/QADashboard/RecipientsWithClassScoresAndGoals/index.js

+ });
+ updateError('');
+ } catch (e) {
+ updateError('Unable to fetch QA data');


no test for this case

thewatermethod · 2024-10-17T14:03:51Z

frontend/src/pages/QADashboard/RecipientsWithOhsStandardFeiGoal/index.js

+ });
+ updateError('');
+ } catch (e) {
+ updateError('Unable to fetch QA data');


same comments as before, no test for this case that I can see, and the function has a typo

added test fixed typo

AdamAdHocTeam · 2024-10-17T17:46:46Z

Verify filters work correctly

First two filters I tried on the landing page:

Report ID contains does not change the result set as far as I can tell, at least on the overview widget

Created on throws an error

This should be fixed in Garrett's latest push.

thewatermethod · 2024-10-17T18:25:07Z

FYI @AdamAdHocTeam, @GarrettEHill Dashboard no longer loads any data at all

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

AdamAdHocTeam · 2024-10-17T21:32:02Z

FYI @AdamAdHocTeam, @GarrettEHill Dashboard no longer loads any data at all

@thewatermethod this should be good now @GarrettEHill resolved the BE issues.

thewatermethod · 2024-10-18T17:30:01Z

@AdamAdHocTeam @GarrettEHill
I noticed that the total number of reports (11,510) on delivery method and percentage of activity reports by role does not change, I think that needs to be hooked up to the backend.

Filters that error:

Created on
Date started
Date ended
Group
Reasons
Recipient name
State, if you pick more than one

Filters that do not seem to update the data (none of the charts, even the ones that would make sense to update, lke the root cause chart)

Please double check these are being applied

Goal status
FEI root cause
Goal text
Target population
Number of recipients
Specialist roles
TTA type

These only apply to the landing page; when I started picking through the sub pages I found similar issues but I'm not going to document them rn

AdamAdHocTeam · 2024-10-18T18:13:41Z

@AdamAdHocTeam @GarrettEHill I noticed that the total number of reports (11,510) on delivery method and percentage of activity reports by role does not change, I think that needs to be hooked up to the backend.

Filters that error:

Created on

Date started

Date ended

Group

Reasons

Recipient name

State, if you pick more than one

Filters that do not seem to update the data (none of the charts, even the ones that would make sense to update, lke the root cause chart)

Please double check these are being applied

Goal status

FEI root cause

Goal text

Target population

Number of recipients

Specialist roles

TTA type

These only apply to the landing page; when I started picking through the sub pages I found similar issues but I'm not going to document them rn

@GarrettEHill can you please have a look at this on Monday seems we are missing data points and filters.

thewatermethod · 2024-10-18T18:55:57Z

frontend/src/widgets/RecipientsWithClassScoresAndGoalsWidget.js

+ const totalRecipients = widgetData ? widgetData.total : 0;
+ const grants = widgetData ? widgetData['grants with class'] : 0;
+ const pct = widgetData ? widgetData['% recipients with class'] : 0;
+ const recipoientsWithClass = widgetData ? widgetData['recipients with class'] : 0;


thewatermethod · 2024-10-18T18:57:37Z

@AdamAdHocTeam

I noticed that the total number of reports (11,510) on delivery method and percentage of activity reports by role does not change, I think that needs to be hooked up to the backend.

This is a frontend change, they were hardcoded in

start to hook up async calls for qa widgets

0b05d01

AdamAdHocTeam changed the base branch from main to al-ttahub-3316-3317-overview-widgets October 1, 2024 15:16

AdamAdHocTeam and others added 28 commits October 1, 2024 15:36

recipients with ohs standard fei goals async

540d854

Merge branch 'al-ttahub-3316-3317-overview-widgets' into al-ttahub-34…

c735cbe

…02-connect-be-overview

updates to for ssdi

14efd3f

Connect delivery method graph

7b9c1d0

Remove console.log

88cc0a2

updates to widgets and tests for ssdi

906c873

Merge branch 'al-ttahub-3316-3317-overview-widgets' into al-ttahub-34…

2faddd0

…02-connect-be-overview

hook up reciepents without tta

9401ea1

Merge branch 'al-ttahub-3316-3317-overview-widgets' into al-ttahub-34…

de607a5

…02-connect-be-overview

Add number of grants with FEI to widget

8a1f13c

hook up fei page

988f57c

adding creator and collaborators to the with_class_page

a9d6168

add grant count to class widget data

ffcd8f2

hook up class

57bc831

hook up sorting and clean up

2123b4c

fix for per page

b6c0880

adding region id

66f3350

hook up links for recipients and goals

3435275

Merge branch 'al-ttahub-3402-connect-be-overview' of https://github.c…

3db19d6

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

Merge branch 'al-ttahub-3316-3317-overview-widgets' into al-ttahub-34…

9dd8268

…02-connect-be-overview

fix links

cb8d503

hook up filter applicable message

6465d39

make sure closed and merged goals are not included

d06b2e1

Merge branch 'al-ttahub-3402-connect-be-overview' of https://github.c…

a5a5a39

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

add tests fix sorting on class

cf23802

Merge branch 'al-ttahub-3402-connect-be-overview' of https://github.c…

c84f338

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

hook up class to new export

3678598

resolve weird collision between sorting and exporting

ac26eea

AdamAdHocTeam marked this pull request as ready for review October 15, 2024 20:41

Merge branch 'al-ttahub-3316-3317-overview-widgets' into al-ttahub-34…

d45be6f

…02-connect-be-overview

fix bad merge of routes

fe6e2a9

thewatermethod reviewed Oct 17, 2024

View reviewed changes

handle divide by zero case

8d4a330

AdamAdHocTeam and others added 4 commits October 17, 2024 14:57

code updates per Matt

faf7c44

fix bugs and add more filters

3f0d96f

Merge branch 'al-ttahub-3402-connect-be-overview' of https://github.c…

020ea4e

…om/HHS/Head-Start-TTADP into al-ttahub-3402-connect-be-overview

add report id to dashboard async and handle for no data returned

f2e6a87

add coverage for null checks

4021036

AdamAdHocTeam requested a review from thewatermethod October 18, 2024 16:13

thewatermethod reviewed Oct 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TTAHUB-3402] Hook up QA widgets to BE #2394

[TTAHUB-3402] Hook up QA widgets to BE #2394

AdamAdHocTeam commented Oct 1, 2024 •

edited

Loading

thewatermethod commented Oct 16, 2024 •

edited

Loading

thewatermethod commented Oct 16, 2024

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024 •

edited

Loading

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

AdamAdHocTeam Oct 18, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

thewatermethod Oct 17, 2024

AdamAdHocTeam Oct 17, 2024

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 17, 2024

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 18, 2024 •

edited

Loading

AdamAdHocTeam commented Oct 18, 2024 •

edited

Loading

Filters that error:

Filters that do not seem to update the data (none of the charts, even the ones that would make sense to update, lke the root cause chart)

thewatermethod Oct 18, 2024

thewatermethod commented Oct 18, 2024

[TTAHUB-3402] Hook up QA widgets to BE #2394

Are you sure you want to change the base?

[TTAHUB-3402] Hook up QA widgets to BE #2394

Conversation

AdamAdHocTeam commented Oct 1, 2024 • edited Loading

Description of change

How to test

Issue(s)

Checklists

Every PR

Before merge to main

Production Deploy

After merge/deploy

thewatermethod commented Oct 16, 2024 • edited Loading

thewatermethod commented Oct 16, 2024

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thewatermethod Oct 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 17, 2024

AdamAdHocTeam commented Oct 17, 2024

thewatermethod commented Oct 18, 2024 • edited Loading

Filters that error:

Filters that do not seem to update the data (none of the charts, even the ones that would make sense to update, lke the root cause chart)

AdamAdHocTeam commented Oct 18, 2024 • edited Loading

Filters that error:

Filters that do not seem to update the data (none of the charts, even the ones that would make sense to update, lke the root cause chart)

Choose a reason for hiding this comment

thewatermethod commented Oct 18, 2024

AdamAdHocTeam commented Oct 1, 2024 •

edited

Loading

thewatermethod commented Oct 16, 2024 •

edited

Loading

thewatermethod Oct 17, 2024 •

edited

Loading

thewatermethod commented Oct 18, 2024 •

edited

Loading

AdamAdHocTeam commented Oct 18, 2024 •

edited

Loading