[TTAHUB-3061] Generate processed dataset to remove PII in CI #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TAHUB-3061/process-data
src/lib/s3.test.js
Outdated
Comment on lines
268
to
275
| it('throws an error if promise rejects', async () => { | ||
| mockS3.deleteObject.mockImplementation( | ||
| () => ({ promise: () => Promise.reject(anotherFakeError) }), | ||
| ); | ||
| const got = deleteFileFromS3(Key, undefined, mockS3); | ||
| await expect(got).rejects.toBe(anotherFakeError); | ||
| expect(mockS3.deleteObject).toHaveBeenCalledWith({ Bucket, Key }); | ||
| }); |
There was a problem hiding this comment.
Is there some reason why you are passing undefined as bucket name? it doesn't seem to be part of the test, and passing it as undefined means it defaults to the destructured value from the s3config function, so line 274 will not pass. I'm just not clear as to what we are trying to test here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
How to test
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy