Activity report pages are navigable via url #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being able to browse to specific report pages via URL has two main advantages: * A user can share/bookmark a specific page * We are setup to directly link to specific sections of the pages
|
Opened against wrong repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The current activity reports page shown is determined by the url. Being able to browse to specific report pages via URL has two main advantages:
Also I added the report pages to the axe testing, and added a file with the urls axe should test. Note the
axe:cicommand no longer works on windows. Also fixed a color contrast accessibility issue in the activity report side nav when a page is selected and has a state ofComplete.How to test
Browse to sandbox. Browsing to different pages will change the url. You can also directly go to specific pages of the report (https://tta-smarthub-sandbox.app.cloud.gov/activity-reports/review)
Issue(s)
Checklist