Add navigator #190
Merged
Add navigator #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The navigator allows us to split up large forms into multiple pages. It has a side navigation that allows any page to be selected. The side nav displays the state of each page.
Switch from using fireEvent to userEvent. Will update additional tests as I come accross them. Reduce the instances of using "act" in tests, now we properly wait for all the rerenders to occur. Some tests still need to use act. Most deal with third party libraries
Conflicts: frontend/src/App.js frontend/src/pages/Unauthenticated/index.js
Conflicts: frontend/yarn.lock
Conflicts: frontend/yarn.lock
Add navigator
rahearn
requested changes
Dec 8, 2020
There was a problem hiding this comment.
Great work, overall. I think there are a couple things that could be slightly improved, but the big change I'd like to see is that the "Not started" tags fail accessibility for contrast: https://app.circleci.com/pipelines/github/adhocteam/Head-Start-TTADP/684/workflows/7799b4b8-0574-4042-ad1b-460d705cdf10/jobs/3019
* Change navigator status colors to be more accessible * Page titles are now most specific to least specific * Add navigator test making sure "complete" state is shown * Fix cucumber test to look for proper label * Activity report uses proper label for "grantee/non-grantee name(s)"
2 tasks
Navigator feedback
rahearn
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The navigator allows us to split up large forms into multiple pages. It has a side navigation that allows any page to be selected. The side navigation displays the state of each page and is stickied to the top of the page. Some notes:
react-helmetto help update page titles. This library helps keep the page title updated with the page the user is viewing in the activity report. Note this library will be replaced withreact-helmet-async(https://github.com/staylor/react-helmet-async) that removes some react deprecation warnings but has the same usage.act(...)in tests. Previously we would get warnings that looked likeWarning: An update to *COMPONENT* inside a test was not wrapped in act(...).. This indicates updates to the DOM were happening outside of a test. I've updated tests to not need to be wrapped in act. Some tests still use act but they deal with third party libraries or using mock timers.fireEventwithuserEventper this suggestion. Will make a separate PR to switch everything overHow to test
OR
localhost:3000/activity-reportIssue(s)
Checklist