-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select main lobe 🔭 🛰️ #736
Conversation
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 96.84% 96.85% +0.01%
==========================================
Files 19 19
Lines 7598 7795 +197
==========================================
+ Hits 7358 7550 +192
- Misses 240 245 +5
Continue to review full report at Codecov.
|
a1dc5a7
to
bb2502d
Compare
df5fd33
to
c599be2
Compare
c6fe9af
to
e889b08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor cosmetic clean-ups needed, and just a couple of comments on plumbing, but should be good to go shortly. thanks for your patience :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good thanks
Filter the fringe-rates from the main lobe using instantaneous fringe rates from https://ui.adsabs.harvard.edu/abs/2016ApJ...820...51P/abstract . Depends on #700 and #747, #757 #759. Closes #737.