Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select main lobe 🔭 🛰️ #736

Merged
merged 84 commits into from
Mar 18, 2022
Merged

Select main lobe 🔭 🛰️ #736

merged 84 commits into from
Mar 18, 2022

Conversation

aewallwi
Copy link
Collaborator

@aewallwi aewallwi commented Sep 4, 2021

Filter the fringe-rates from the main lobe using instantaneous fringe rates from https://ui.adsabs.harvard.edu/abs/2016ApJ...820...51P/abstract . Depends on #700 and #747, #757 #759. Closes #737.

@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #736 (e19191b) into main (8b51c52) will increase coverage by 0.01%.
The diff coverage is 97.73%.

@@            Coverage Diff             @@
##             main     #736      +/-   ##
==========================================
+ Coverage   96.84%   96.85%   +0.01%     
==========================================
  Files          19       19              
  Lines        7598     7795     +197     
==========================================
+ Hits         7358     7550     +192     
- Misses        240      245       +5     
Impacted Files Coverage Δ
hera_cal/frf.py 97.38% <97.68%> (+0.04%) ⬆️
hera_cal/chunker.py 100.00% <100.00%> (ø)
hera_cal/delay_filter.py 100.00% <100.00%> (ø)
hera_cal/redcal.py 99.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b51c52...e19191b. Read the comment docs.

@aewallwi aewallwi marked this pull request as draft September 4, 2021 05:32
@aewallwi aewallwi mentioned this pull request Oct 17, 2021
@aewallwi aewallwi marked this pull request as ready for review November 23, 2021 02:38
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
Copy link
Member

@nkern nkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor cosmetic clean-ups needed, and just a couple of comments on plumbing, but should be good to go shortly. thanks for your patience :)

hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
hera_cal/frf.py Outdated Show resolved Hide resolved
@nkern nkern self-requested a review March 18, 2022 18:14
Copy link
Member

@nkern nkern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good thanks

@jsdillon jsdillon merged commit 9cd3b8b into main Mar 18, 2022
@jsdillon jsdillon deleted the select_main_lobe branch March 18, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select fringe-rates in the main beam lobe
5 participants