Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace find_module and load_module for Python 3.12 compatibility #58

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Replace find_module and load_module for Python 3.12 compatibility #58

merged 1 commit into from
Mar 11, 2024

Conversation

GraemeWatt
Copy link
Member

@GraemeWatt GraemeWatt commented Mar 11, 2024 •
edited
Loading

  • find_module deprecated since Python 3.10 and removed in Python 3.12.
  • load_module deprecated since Python 3.4.
  • Closes Python 3.12 compatibility #57.

@GraemeWatt
global: replace find_module and load_module
033f05a 
* find_module deprecated since Python 3.10 and removed in Python 3.12.
* load_module deprecated since Python 3.4.
@coveralls
Copy link

Coverage Status

coverage: 91.731% (+0.02%) from 91.708%
when pulling 033f05a on replace_find_module
into 26658e4 on main.

@GraemeWatt GraemeWatt requested a review from 20DM March 11, 2024 12:55
@GraemeWatt GraemeWatt mentioned this pull request Mar 11, 2024
Closed
20DM
20DM approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@20DM 20DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch - I pulled this on my Mac and can confirm that this works fine with Python 3.12! 🙏

@GraemeWatt GraemeWatt merged commit 1e5b10f into main Mar 11, 2024
7 checks passed
@GraemeWatt GraemeWatt deleted the replace_find_module branch March 11, 2024 13:31
@GraemeWatt GraemeWatt changed the title Replace find_module and load_module for Python 3.12 compatibilty Replace find_module and load_module for Python 3.12 compatibility Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@20DM 20DM 20DM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.12 compatibility
3 participants
@GraemeWatt @coveralls @20DM