Make disks show info about unmounted disks as well, first effort #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it's really useful but if you're willing to implement it for all sysinfo supported systems, I'm fine with it. |
|
|
||
| container.push(new_disk( | ||
| disk.as_ref(), | ||
| mount_point, |
There was a problem hiding this comment.
With this new feature, I think mount_point should become an enum looking like this:
enum MountPoint {
Path(Path)
Swap,
Unmounted,
}
|
I don't have a Mac (and don't know it's system), so I doubt I can implement for it. But I can try with Windows. |
sigsegved
reviewed
Jan 31, 2025
| // The list of unmounted disks, initially it include all disks | ||
| let mut unmounted = procfs_disk_stats | ||
| .keys() | ||
| .map(|disk| "/dev/".to_owned() + disk) |
There was a problem hiding this comment.
The /dev/ part? I suppose it could be.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We clone the keys of
procfs_disk_statsto create a list of all disks, including unmounted ones, and let's call thatunmounted. Then after adding the mounted disks (and at the same time removing those disks from theunmounted), we can iterate over unmounted and add the remaining disks.Unmounted disks will have "Unknown" file system and empty mount point, except Zram, which has "swap" file system and "[SWAP]" mount point (like lsblk).