Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close select tab by label / select tab by label #2101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Arwez
Copy link

@Arwez Arwez commented Jun 18, 2022

No description provided.

@Davidy22
Copy link
Collaborator

Davidy22 commented Jun 18, 2022

Looks like you need to do a passthrough of black to make CI pass, and maybe there's some more to do for tests after that. CI should run on your repo too, so you can see the results of most of the runs without needing to wait for me to approve the run over here.

As for technical changes, this PR has made me aware that while we have a close_tab defined and written, it's not actually connected to a front facing guake flag for whatever reason. If we presume that oversight didn't exist and we did have a close tab flag, I believe the close_tab_by_label() in guake_app is unnecessary because we can functionally duplicate it in the dbusiface by calling select_tab_by_labe()l followed by a close_tab(). I can add the flag for a plain --close-tab flag myself or you could fold that into here as a thematically similar function if you want to.

@ianpilogov
Copy link

Any updates on this feature? I'd like to close tabs from CLI interface for my automation, but looks like guake can't do it.

@Davidy22
Copy link
Collaborator

Davidy22 commented Aug 1, 2022

Somewhat busy personally but if you're willing to fork and fix up this branch and PR it I can merge it if it looks good and passes CI

Copy link

@novaTopFlex novaTopFlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the code; the code looks appropriate to the situation and correcrtions have been made successfully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants