feat: Remove underlines from quick-open targets when quick-open disabled

Fixes #2225

docs/source/contributing/hacking.rst

@@ -74,7 +74,7 @@ building the distribution packages.
 
 Same goes for the `ChangeLog` file.
 
-Versionning
+Versioning
 -----------
 
 Versioning is automatically done using git tags. When a semver tag is pushed, a new version

guake/terminal.py

@@ -101,7 +101,10 @@ def __init__(self, guake):
         super().__init__()
         self.guake = guake
         self.configure_terminal()
-        self.add_matches()
+
+        if self.guake.settings.general.get_boolean("quick-open-enable"):
+            self.add_matches()
+
         self.handler_ids = []
         self.handler_ids.append(self.connect("button-press-event", self.button_press))
         self.connect("child-exited", self.on_child_exited)  # Call on_child_exited, don't remove it
@@ -347,13 +350,15 @@ def button_press(self, terminal, event):
         handle the matched resource uri.
         """
         self.matched_value = ""
-        if (Vte.MAJOR_VERSION, Vte.MINOR_VERSION) >= (0, 46):
-            matched_string = self.match_check_event(event)
-        else:
-            matched_string = self.match_check(
-                int(event.x / self.get_char_width()),
-                int(event.y / self.get_char_height()),
-            )
+
+        if self.guake.settings.general.get_boolean("quick-open-enable"):
+            if (Vte.MAJOR_VERSION, Vte.MINOR_VERSION) >= (0, 46):
+                matched_string = self.match_check_event(event)
+            else:
+                matched_string = self.match_check(
+                    int(event.x / self.get_char_width()),
+                    int(event.y / self.get_char_height()),
+                )
 
         self.found_link = None
 

releasenotes/notes/disable-underline-8848025f0ec292d4.yaml

@@ -0,0 +1,2 @@
+release_summary: >
+  Added code to remove underlines from quick-open targets when quick-open disabled