-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(back): add streaming layout api #325
base: main
Are you sure you want to change the base?
Conversation
server/model/domain/application.go
Outdated
|
||
type Application struct { | ||
ID string `json:"id"` | ||
Deadline time.Time `json:"deadLine"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deadline time.Time `json:"deadLine"` | |
Deadline time.Time `json:"deadline"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed: a04ec26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あとgodocが足りていません
publicなstruct、funcには全部ドキュメント書くぐらいのつもりでいてください
server/controller/layout.go
Outdated
|
||
import "github.com/labstack/echo" | ||
|
||
type LayoutController interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Controllerはinterface要らない気がする
interfaceのメソッドの引数に ctx echo.Context
が漏れ出てる時点で…(そうならざるを得ないし、そうなるからinterfaceである意味がない)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かにそれはそうだった。
だとしたら、server/controller/echo
以下のファイルはserver/controller
に移してもいいですかね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました 430904c |
ローカル変数や外部ライブラリのメソッド呼び出しにコメントつけてもそれはただのコメントでgodocではありません メソッドやstructを定義している場所にコメントを書いてください |
まだ実装中ですが、実装方針で不穏な箇所や要件と違う箇所があれば指摘してください🙇♂️
現在RepositoryはInterfaceだけ定義しています。定義終わりました。Controllerは実体も定義済みです。
Related Issues