Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(back): add streaming layout api #325

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

dino3616
Copy link
Member

@dino3616 dino3616 commented Sep 16, 2022

まだ実装中ですが、実装方針で不穏な箇所や要件と違う箇所があれば指摘してください🙇‍♂️

現在RepositoryはInterfaceだけ定義しています。 定義終わりました。
Controllerは実体も定義済みです。

Related Issues


type Application struct {
ID string `json:"id"`
Deadline time.Time `json:"deadLine"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deadline time.Time `json:"deadLine"`
Deadline time.Time `json:"deadline"`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed: a04ec26

Copy link
Collaborator

@mirror-kt mirror-kt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとgodocが足りていません
publicなstruct、funcには全部ドキュメント書くぐらいのつもりでいてください


import "github.com/labstack/echo"

type LayoutController interface {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Controllerはinterface要らない気がする
interfaceのメソッドの引数に ctx echo.Context が漏れ出てる時点で…(そうならざるを得ないし、そうなるからinterfaceである意味がない)

Copy link
Member Author

@dino3616 dino3616 Sep 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かにそれはそうだった。
だとしたら、server/controller/echo以下のファイルはserver/controllerに移してもいいですかね?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server/controller/echo/routes.go Outdated Show resolved Hide resolved
@dino3616
Copy link
Member Author

あとgodocが足りていません

修正しました 430904c

@mirror-kt
Copy link
Collaborator

mirror-kt commented Sep 17, 2022

あとgodocが足りていません

修正しました 430904c

ローカル変数や外部ライブラリのメソッド呼び出しにコメントつけてもそれはただのコメントでgodocではありません

メソッドやstructを定義している場所にコメントを書いてください
FYI: https://tip.golang.org/doc/comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配信レイアウト関連のAPI
3 participants