Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gridplus safe-card modifications #43

Closed
wants to merge 7 commits into from
Closed

Conversation

phreaknik
Copy link

@phreaknik phreaknik commented Aug 26, 2019

MVP modifications necessary to enable Gridplus certificate based pairing. Unit tests remain unimplemented (see #44).

Functional testing in progress with Lattice client.

Copy link

@alex-miller-0 alex-miller-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the whole thing, but I'm pretty sure the transient array is your problem. You should definitely change that

src/main/java/im/status/keycard/SecureChannel.java Outdated Show resolved Hide resolved
@phreaknik phreaknik force-pushed the safecard-refactor branch 10 times, most recently from 0d4a972 to 1c95dc5 Compare August 29, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants