-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(elasticsearch): use _index
as greptimedb table in log ingestion and add /${index}/_bulk
API
#5335
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
850c4cb
to
ddf90de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
…stion and add `/${index}/_bulk` API Signed-off-by: zyy17 <[email protected]>
ddf90de
to
66005e6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5335 +/- ##
==========================================
- Coverage 84.13% 83.90% -0.23%
==========================================
Files 1181 1181
Lines 220931 221090 +159
==========================================
- Hits 185889 185515 -374
- Misses 35042 35575 +533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By the way, we may also want to accept table names specified in the HTTP header. Since we have all kinds of protocols using each of their own table naming methods, we can build a common extraction function to provide Greptime header parameters at the bottom and layered protocol-specified parameters at the top, much like our layered configuration structure.
…stion and add `/${index}/_bulk` API (GreptimeTeam#5335) * refactor(elasticsearch): use `_index` as greptimedb table in log ingestion and add `/${index}/_bulk` API Signed-off-by: zyy17 <[email protected]> * refactor: code review --------- Signed-off-by: zyy17 <[email protected]>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
_index
from bulk requests as greptimedb table;${index}/_bulk
API;LogIngestRequest
and refactoringest_logs_inner
to support ingest logs into multiple tables by one request;PR Checklist
Please convert it to a draft if some of the following conditions are not met.