Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to standard messages #43

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Change to standard messages #43

merged 2 commits into from
Dec 7, 2023

Conversation

IntelligentJackal
Copy link

Overview

Impact

  • Packages that use the custom message from robot_localization have to depend on robot_localization. That removes build and use flexibility. This PR moves to standard messages to avoid that dependency.

Testing

  • Tested in simulation - messages published as expected

@IntelligentJackal IntelligentJackal merged commit a205986 into noetic-devel Dec 7, 2023
2 checks passed
@IntelligentJackal IntelligentJackal deleted the IntelligentJackal/move-to-std-msgs branch December 7, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tiz lucas-tiz lucas-tiz approved these changes

@AGummyBear AGummyBear AGummyBear approved these changes

@1hada 1hada Awaiting requested review from 1hada

@rm-greenzie rm-greenzie Awaiting requested review from rm-greenzie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IntelligentJackal @AGummyBear @lucas-tiz @chacalnoir