-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sign up #328
base: main
Are you sure you want to change the base?
Create sign up #328
Conversation
<TextInput | ||
style={styles.input} | ||
value={password} | ||
onChange={e => setPassword} | ||
secureTextEntry={true} | ||
placeholder="Password"></TextInput> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syntax is incorrect. Use instead for proper JSX formatting.
To reduce code duplication, refactor repeated logic into a reusable component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have both a signup screen and a register screen with almost the same code? Consider merging them into a single component to avoid duplication
Description
Please provide a clear and concise description of the changes made, including the purpose and context.
Fixes: # (issue number)
or
Resolves: # (issue number)
Changes Made
Changes in
apps
folder (specify the app and briefly describe the changes):Web
Native
Changes in
packages
folder (specify the package and briefly describe the changes):Core
Type of Change
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
(Optional) Add any additional comments or notes for reviewers here.