-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nestjs user api and e2e tests (#256) #257
feat: nestjs user api and e2e tests (#256) #257
Conversation
e120558
to
3ebfef1
Compare
@dorukucak you finish it? Can you e2e test pass? Please add your command to run your e2e in the readme.md, then we can merge your code. |
Working on implementing keycloak. Couldn't find a keycloak endpoint to register user. Do we have that? |
@pierrelstan we need your help here |
@dorukucak I think these links could help find the register endpoint.:
and the implementation of the register API endpoint is in the web (nextjs) under the path src/app/api/auth/signup. If you have any questions, feel free to let me know. |
8a2debc
to
35cc540
Compare
Okay so, I had to create a Keycloak service account and give it manage-user privilages. Now we can succesfully create users using the /register endpoint. However, we need to handle API secrets before we can run tests on github workflow etc. |
35cc540
to
f96c4e0
Compare
@dorukucak Could you kindly resolve the merge conflicts? |
f96c4e0
to
f77b21d
Compare
resolved conflicts in yarn.lock |
06c1700
to
d4421e8
Compare
This is ready |
a4e2b48
to
1618cdd
Compare
|
1618cdd
to
db5f6de
Compare
Cross-env is a good practice, thanks. |
Fixed: #256
Description
Created nestjs server and implemented a user API that expose an /register endpoint.
Resolves: # (#256)
Changes Made
Changes in
apps
folder (specify the app and briefly describe the changes):Web
Native
Api
Changes in
packages
folder (specify the package and briefly describe the changes):Core
Type of Change
Screenshots
How Has This Been Tested?
Checklist:
Additional Comments
(Optional) Add any additional comments or notes for reviewers here.