-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dojo 53] CI にテストを追加 #34
base: main
Are you sure you want to change the base?
Conversation
.github/workflows/ci-setup.yaml
Outdated
cache: 'pnpm' | ||
|
||
- name: cache-node-modules | ||
uses: actions/cache@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4が最新のようですが、v3 の理由は何かありますか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm を使うと node_modulesディレクトリ以下には、ショートカットリンクしか残らないです。モジュール本体は、~/.pnpm-store
にインストールされます。
なので ~/.pnpm-store
もキャッシュすると良いでしょう
- name: Cache pnpm store
uses: actions/cache@v4
with:
path: ['~/.pnpm-store', 'node_modules']
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('pnpm-lock.yaml') }}
.github/workflows/test.yaml
Outdated
|
||
jobs: | ||
test: | ||
name: Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test だと目的が明確ではないですね。安田さんが実験するために置いたファイルなのか、npm test
を実行するためのファイルなのかが分かりません。
Run test
とかどうでしょうか。
Jira
https://alpha-dojo.atlassian.net/browse/DOJO-53
内容