add colorToRGBArray function #808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could update our build pipeline to supply tokens defined as rgb values (or oklch or ...) maybe this function is a practical solution for now though? |
That would help when assigning something to be, for example, our primary categorical color. But it wouldn't help for when we're applying a continuous color scale, as things like the D3 color scales don't directly give colors in this format. |
jamesscottbrown
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
colorToRGBArrayfunction. This is needed in most projects that use Deck.gl, since Deck.gl requires colors to specified as an array of R/G/B values, and this is not the format in which our color tokens are defined (or which is returend by our color scales).